From 383081bdb24a7ba414d137c8b240892b83c2b208 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Mon, 25 Mar 2024 13:13:46 -0700 Subject: [PATCH 1/3] upgrade axe-core to 4.9 --- cli/test/smokehouse/test-definitions/a11y.js | 2 +- package.json | 2 +- yarn.lock | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cli/test/smokehouse/test-definitions/a11y.js b/cli/test/smokehouse/test-definitions/a11y.js index 555a4fd70356..1a1393878e82 100644 --- a/cli/test/smokehouse/test-definitions/a11y.js +++ b/cli/test/smokehouse/test-definitions/a11y.js @@ -235,7 +235,7 @@ const expectations = { 'type': 'node', 'selector': 'body > section > div#aria-required-children', 'snippet': '
', - 'explanation': 'Fix any of the following:\n Required ARIA child role not present: listitem\n Element uses aria-busy="true" while showing a loader', + 'explanation': 'Fix any of the following:\n Required ARIA child role not present: listitem', 'nodeLabel': 'Item', }, }, diff --git a/package.json b/package.json index d2af1985c585..18df2dcc421d 100644 --- a/package.json +++ b/package.json @@ -181,7 +181,7 @@ "dependencies": { "@paulirish/trace_engine": "^0.0.12", "@sentry/node": "^6.17.4", - "axe-core": "^4.8.4", + "axe-core": "^4.9.0", "chrome-launcher": "^1.1.1", "configstore": "^5.0.1", "csp_evaluator": "1.1.1", diff --git a/yarn.lock b/yarn.lock index 7b15389a0e87..eceaf4a0a450 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1980,10 +1980,10 @@ aws4@^1.8.0: resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.8.0.tgz#f0e003d9ca9e7f59c7a508945d7b2ef9a04a542f" integrity sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ== -axe-core@^4.8.4: - version "4.8.4" - resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.8.4.tgz#90db39a2b316f963f00196434d964e6e23648643" - integrity sha512-CZLSKisu/bhJ2awW4kJndluz2HLZYIHh5Uy1+ZwDRkJi69811xgIXXfdU9HSLX0Th+ILrHj8qfL/5wzamsFtQg== +axe-core@^4.9.0: + version "4.9.0" + resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.9.0.tgz#b18971494551ab39d4ff5f7d4c6411bd20cc7c2a" + integrity sha512-H5orY+M2Fr56DWmMFpMrq5Ge93qjNdPVqzBv5gWK3aD1OvjBEJlEzxf09z93dGVQeI0LiW+aCMIx1QtShC/zUw== b4a@^1.6.4: version "1.6.4" From e0be0d9fa569c6d2666bf5670065ff1c11a9c0b9 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Mon, 25 Mar 2024 13:22:23 -0700 Subject: [PATCH 2/3] doc links --- core/audits/accessibility/accesskeys.js | 2 +- .../audits/accessibility/aria-allowed-attr.js | 2 +- .../audits/accessibility/aria-allowed-role.js | 2 +- .../audits/accessibility/aria-command-name.js | 2 +- core/audits/accessibility/aria-dialog-name.js | 2 +- core/audits/accessibility/aria-hidden-body.js | 2 +- .../audits/accessibility/aria-hidden-focus.js | 2 +- .../accessibility/aria-input-field-name.js | 2 +- core/audits/accessibility/aria-meter-name.js | 2 +- .../accessibility/aria-progressbar-name.js | 2 +- .../accessibility/aria-required-attr.js | 2 +- .../accessibility/aria-required-children.js | 2 +- .../accessibility/aria-required-parent.js | 2 +- core/audits/accessibility/aria-roles.js | 2 +- core/audits/accessibility/aria-text.js | 2 +- .../accessibility/aria-toggle-field-name.js | 2 +- .../audits/accessibility/aria-tooltip-name.js | 2 +- .../accessibility/aria-treeitem-name.js | 2 +- .../accessibility/aria-valid-attr-value.js | 2 +- core/audits/accessibility/aria-valid-attr.js | 2 +- core/audits/accessibility/button-name.js | 2 +- core/audits/accessibility/bypass.js | 2 +- core/audits/accessibility/color-contrast.js | 2 +- core/audits/accessibility/definition-list.js | 2 +- core/audits/accessibility/dlitem.js | 2 +- core/audits/accessibility/document-title.js | 2 +- .../accessibility/duplicate-id-active.js | 2 +- .../audits/accessibility/duplicate-id-aria.js | 2 +- core/audits/accessibility/empty-heading.js | 2 +- .../form-field-multiple-labels.js | 2 +- core/audits/accessibility/frame-title.js | 2 +- core/audits/accessibility/heading-order.js | 2 +- core/audits/accessibility/html-has-lang.js | 2 +- core/audits/accessibility/html-lang-valid.js | 2 +- .../accessibility/html-xml-lang-mismatch.js | 2 +- .../identical-links-same-purpose.js | 2 +- core/audits/accessibility/image-alt.js | 2 +- .../accessibility/image-redundant-alt.js | 2 +- .../audits/accessibility/input-button-name.js | 2 +- core/audits/accessibility/input-image-alt.js | 2 +- .../label-content-name-mismatch.js | 2 +- core/audits/accessibility/label.js | 2 +- .../audits/accessibility/landmark-one-main.js | 2 +- .../accessibility/link-in-text-block.js | 2 +- core/audits/accessibility/link-name.js | 2 +- core/audits/accessibility/list.js | 2 +- core/audits/accessibility/listitem.js | 2 +- core/audits/accessibility/meta-refresh.js | 2 +- core/audits/accessibility/meta-viewport.js | 2 +- core/audits/accessibility/object-alt.js | 2 +- core/audits/accessibility/select-name.js | 2 +- core/audits/accessibility/skip-link.js | 2 +- core/audits/accessibility/tabindex.js | 2 +- .../accessibility/table-duplicate-name.js | 2 +- .../accessibility/table-fake-caption.js | 2 +- core/audits/accessibility/target-size.js | 2 +- core/audits/accessibility/td-has-header.js | 2 +- core/audits/accessibility/td-headers-attr.js | 2 +- .../audits/accessibility/th-has-data-cells.js | 2 +- core/audits/accessibility/valid-lang.js | 2 +- core/audits/accessibility/video-caption.js | 2 +- .../reports/sample-flow-result.json | 366 +++++++++--------- core/test/results/sample_v2.json | 122 +++--- shared/localization/locales/en-US.json | 122 +++--- shared/localization/locales/en-XL.json | 122 +++--- 65 files changed, 427 insertions(+), 427 deletions(-) diff --git a/core/audits/accessibility/accesskeys.js b/core/audits/accessibility/accesskeys.js index 38c836b1101b..11fa7b3ba4fb 100644 --- a/core/audits/accessibility/accesskeys.js +++ b/core/audits/accessibility/accesskeys.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Access keys let users quickly focus a part of the page. For proper ' + 'navigation, each access key must be unique. ' + - '[Learn more about access keys](https://dequeuniversity.com/rules/axe/4.8/accesskeys).', + '[Learn more about access keys](https://dequeuniversity.com/rules/axe/4.9/accesskeys).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-allowed-attr.js b/core/audits/accessibility/aria-allowed-attr.js index a500f5fb1a88..2dd73ab511bf 100644 --- a/core/audits/accessibility/aria-allowed-attr.js +++ b/core/audits/accessibility/aria-allowed-attr.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Each ARIA `role` supports a specific subset of `aria-*` attributes. ' + 'Mismatching these invalidates the `aria-*` attributes. [Learn ' + - 'how to match ARIA attributes to their roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-attr).', + 'how to match ARIA attributes to their roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-attr).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-allowed-role.js b/core/audits/accessibility/aria-allowed-role.js index 39e975cc8d5a..d6ab5849ae36 100644 --- a/core/audits/accessibility/aria-allowed-role.js +++ b/core/audits/accessibility/aria-allowed-role.js @@ -22,7 +22,7 @@ const UIStrings = { 'the web page. If the `role` values are misspelled, not existing ARIA `role` values, or ' + 'abstract roles, then the purpose of the element will not be communicated to users of ' + 'assistive technologies. ' + - '[Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role).', + '[Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-command-name.js b/core/audits/accessibility/aria-command-name.js index 07536007a619..af493cca2cf7 100644 --- a/core/audits/accessibility/aria-command-name.js +++ b/core/audits/accessibility/aria-command-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if important HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: '`button`, `link`, and `menuitem` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for HTML elements. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When an element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to make command elements more accessible](https://dequeuniversity.com/rules/axe/4.8/aria-command-name).', + description: 'When an element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to make command elements more accessible](https://dequeuniversity.com/rules/axe/4.9/aria-command-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-dialog-name.js b/core/audits/accessibility/aria-dialog-name.js index 72e6f5fae36b..1a991d072528 100644 --- a/core/audits/accessibility/aria-dialog-name.js +++ b/core/audits/accessibility/aria-dialog-name.js @@ -21,7 +21,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for ARIA dialog elements. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'ARIA dialog elements without accessible names may prevent screen readers users ' + 'from discerning the purpose of these elements. ' + - '[Learn how to make ARIA dialog elements more accessible](https://dequeuniversity.com/rules/axe/4.8/aria-dialog-name).', + '[Learn how to make ARIA dialog elements more accessible](https://dequeuniversity.com/rules/axe/4.9/aria-dialog-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-hidden-body.js b/core/audits/accessibility/aria-hidden-body.js index 33fdbd304e0d..1b5d2ca7aab0 100644 --- a/core/audits/accessibility/aria-hidden-body.js +++ b/core/audits/accessibility/aria-hidden-body.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if the html element does not have an aria-hidden attribute set on it. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: '`[aria-hidden="true"]` is present on the document ``', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'Assistive technologies, like screen readers, work inconsistently when `aria-hidden="true"` is set on the document ``. [Learn how `aria-hidden` affects the document body](https://dequeuniversity.com/rules/axe/4.8/aria-hidden-body).', + description: 'Assistive technologies, like screen readers, work inconsistently when `aria-hidden="true"` is set on the document ``. [Learn how `aria-hidden` affects the document body](https://dequeuniversity.com/rules/axe/4.9/aria-hidden-body).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-hidden-focus.js b/core/audits/accessibility/aria-hidden-focus.js index e328ea2d5ed0..e596c377dcab 100644 --- a/core/audits/accessibility/aria-hidden-focus.js +++ b/core/audits/accessibility/aria-hidden-focus.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if all elements that have an aria-hidden attribute do not contain focusable descendent elements. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: '`[aria-hidden="true"]` elements contain focusable descendents', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'Focusable descendents within an `[aria-hidden="true"]` element prevent those interactive elements from being available to users of assistive technologies like screen readers. [Learn how `aria-hidden` affects focusable elements](https://dequeuniversity.com/rules/axe/4.8/aria-hidden-focus).', + description: 'Focusable descendents within an `[aria-hidden="true"]` element prevent those interactive elements from being available to users of assistive technologies like screen readers. [Learn how `aria-hidden` affects focusable elements](https://dequeuniversity.com/rules/axe/4.9/aria-hidden-focus).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-input-field-name.js b/core/audits/accessibility/aria-input-field-name.js index 9a7ec3acd650..6b44df5182d6 100644 --- a/core/audits/accessibility/aria-input-field-name.js +++ b/core/audits/accessibility/aria-input-field-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks that all ARIA input fields have an accessible name. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA input fields do not have accessible names', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When an input field doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about input field labels](https://dequeuniversity.com/rules/axe/4.8/aria-input-field-name).', + description: 'When an input field doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about input field labels](https://dequeuniversity.com/rules/axe/4.9/aria-input-field-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-meter-name.js b/core/audits/accessibility/aria-meter-name.js index 5381c37d6878..67a75c79f598 100644 --- a/core/audits/accessibility/aria-meter-name.js +++ b/core/audits/accessibility/aria-meter-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if meter HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA `meter` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for HTML 'meter' elements. This is displayed after a user expands the section to see more. No character length limits. 'Learn how...' becomes link text to additional documentation. */ - description: 'When a meter element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to name `meter` elements](https://dequeuniversity.com/rules/axe/4.8/aria-meter-name).', + description: 'When a meter element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to name `meter` elements](https://dequeuniversity.com/rules/axe/4.9/aria-meter-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-progressbar-name.js b/core/audits/accessibility/aria-progressbar-name.js index 4ff026c6a66a..4ccd61bea88e 100644 --- a/core/audits/accessibility/aria-progressbar-name.js +++ b/core/audits/accessibility/aria-progressbar-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if progressbar HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA `progressbar` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When a `progressbar` element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to label `progressbar` elements](https://dequeuniversity.com/rules/axe/4.8/aria-progressbar-name).', + description: 'When a `progressbar` element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to label `progressbar` elements](https://dequeuniversity.com/rules/axe/4.9/aria-progressbar-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-required-attr.js b/core/audits/accessibility/aria-required-attr.js index 103b79a9ea2b..a336d193071d 100644 --- a/core/audits/accessibility/aria-required-attr.js +++ b/core/audits/accessibility/aria-required-attr.js @@ -19,7 +19,7 @@ const UIStrings = { failureTitle: '`[role]`s do not have all required `[aria-*]` attributes', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Some ARIA roles have required attributes that describe the state ' + - 'of the element to screen readers. [Learn more about roles and required attributes](https://dequeuniversity.com/rules/axe/4.8/aria-required-attr).', + 'of the element to screen readers. [Learn more about roles and required attributes](https://dequeuniversity.com/rules/axe/4.9/aria-required-attr).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-required-children.js b/core/audits/accessibility/aria-required-children.js index eeb809de387b..0df1bf04dead 100644 --- a/core/audits/accessibility/aria-required-children.js +++ b/core/audits/accessibility/aria-required-children.js @@ -23,7 +23,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Some ARIA parent roles must contain specific child roles to perform ' + 'their intended accessibility functions. ' + - '[Learn more about roles and required children elements](https://dequeuniversity.com/rules/axe/4.8/aria-required-children).', + '[Learn more about roles and required children elements](https://dequeuniversity.com/rules/axe/4.9/aria-required-children).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-required-parent.js b/core/audits/accessibility/aria-required-parent.js index 9cfd67cd5a21..215101342b1b 100644 --- a/core/audits/accessibility/aria-required-parent.js +++ b/core/audits/accessibility/aria-required-parent.js @@ -21,7 +21,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Some ARIA child roles must be contained by specific parent roles to ' + 'properly perform their intended accessibility functions. ' + - '[Learn more about ARIA roles and required parent element](https://dequeuniversity.com/rules/axe/4.8/aria-required-parent).', + '[Learn more about ARIA roles and required parent element](https://dequeuniversity.com/rules/axe/4.9/aria-required-parent).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-roles.js b/core/audits/accessibility/aria-roles.js index bed8c31986fd..368d0f8cb926 100644 --- a/core/audits/accessibility/aria-roles.js +++ b/core/audits/accessibility/aria-roles.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'ARIA roles must have valid values in order to perform their ' + 'intended accessibility functions. ' + - '[Learn more about valid ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-roles).', + '[Learn more about valid ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-roles).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-text.js b/core/audits/accessibility/aria-text.js index 6152ebdbd291..751357b725b8 100644 --- a/core/audits/accessibility/aria-text.js +++ b/core/audits/accessibility/aria-text.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Adding `role=text` around a text node split by markup enables VoiceOver to treat ' + 'it as one phrase, but the element\'s focusable descendents will not be announced. ' + - '[Learn more about the `role=text` attribute](https://dequeuniversity.com/rules/axe/4.8/aria-text).', + '[Learn more about the `role=text` attribute](https://dequeuniversity.com/rules/axe/4.9/aria-text).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-toggle-field-name.js b/core/audits/accessibility/aria-toggle-field-name.js index 4ece39c226c9..51d63460d4e6 100644 --- a/core/audits/accessibility/aria-toggle-field-name.js +++ b/core/audits/accessibility/aria-toggle-field-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks that all ARIA toggle fields have an accessible name. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA toggle fields do not have accessible names', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When a toggle field doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about toggle fields](https://dequeuniversity.com/rules/axe/4.8/aria-toggle-field-name).', + description: 'When a toggle field doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about toggle fields](https://dequeuniversity.com/rules/axe/4.9/aria-toggle-field-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-tooltip-name.js b/core/audits/accessibility/aria-tooltip-name.js index 4aeeea77d1a7..7662c017c49c 100644 --- a/core/audits/accessibility/aria-tooltip-name.js +++ b/core/audits/accessibility/aria-tooltip-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if tooltip HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA `tooltip` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for HTML 'tooltip' elements. This is displayed after a user expands the section to see more. No character length limits. 'Learn how...' becomes link text to additional documentation. */ - description: 'When a tooltip element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to name `tooltip` elements](https://dequeuniversity.com/rules/axe/4.8/aria-tooltip-name).', + description: 'When a tooltip element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to name `tooltip` elements](https://dequeuniversity.com/rules/axe/4.9/aria-tooltip-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-treeitem-name.js b/core/audits/accessibility/aria-treeitem-name.js index 39a8b1c8c95c..e602553680a3 100644 --- a/core/audits/accessibility/aria-treeitem-name.js +++ b/core/audits/accessibility/aria-treeitem-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if treeitem HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA `treeitem` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for HTML elements. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When a `treeitem` element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about labeling `treeitem` elements](https://dequeuniversity.com/rules/axe/4.8/aria-treeitem-name).', + description: 'When a `treeitem` element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about labeling `treeitem` elements](https://dequeuniversity.com/rules/axe/4.9/aria-treeitem-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-valid-attr-value.js b/core/audits/accessibility/aria-valid-attr-value.js index 9c52a3b847ec..6b0006f93efb 100644 --- a/core/audits/accessibility/aria-valid-attr-value.js +++ b/core/audits/accessibility/aria-valid-attr-value.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Assistive technologies, like screen readers, can\'t interpret ARIA ' + 'attributes with invalid values. [Learn ' + - 'more about valid values for ARIA attributes](https://dequeuniversity.com/rules/axe/4.8/aria-valid-attr-value).', + 'more about valid values for ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-valid-attr-value).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-valid-attr.js b/core/audits/accessibility/aria-valid-attr.js index 029b7c7a66bb..6d8cc27d5cff 100644 --- a/core/audits/accessibility/aria-valid-attr.js +++ b/core/audits/accessibility/aria-valid-attr.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Assistive technologies, like screen readers, can\'t interpret ARIA ' + 'attributes with invalid names. [Learn ' + - 'more about valid ARIA attributes](https://dequeuniversity.com/rules/axe/4.8/aria-valid-attr).', + 'more about valid ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-valid-attr).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/button-name.js b/core/audits/accessibility/button-name.js index 93f00f18d8ff..8d6cb2d58b8c 100644 --- a/core/audits/accessibility/button-name.js +++ b/core/audits/accessibility/button-name.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'When a button doesn\'t have an accessible name, screen readers announce it ' + 'as "button", making it unusable for users who rely on screen readers. ' + - '[Learn how to make buttons more accessible](https://dequeuniversity.com/rules/axe/4.8/button-name).', + '[Learn how to make buttons more accessible](https://dequeuniversity.com/rules/axe/4.9/button-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/bypass.js b/core/audits/accessibility/bypass.js index 491bd5be13fa..b49c67cdf3d6 100644 --- a/core/audits/accessibility/bypass.js +++ b/core/audits/accessibility/bypass.js @@ -21,7 +21,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Adding ways to bypass repetitive content lets keyboard users navigate the ' + 'page more efficiently. ' + - '[Learn more about bypass blocks](https://dequeuniversity.com/rules/axe/4.8/bypass).', + '[Learn more about bypass blocks](https://dequeuniversity.com/rules/axe/4.9/bypass).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/color-contrast.js b/core/audits/accessibility/color-contrast.js index e3834f68a186..21e9205e8027 100644 --- a/core/audits/accessibility/color-contrast.js +++ b/core/audits/accessibility/color-contrast.js @@ -21,7 +21,7 @@ const UIStrings = { 'sufficient contrast ratio.', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Low-contrast text is difficult or impossible for many users to read. ' + - '[Learn how to provide sufficient color contrast](https://dequeuniversity.com/rules/axe/4.8/color-contrast).', + '[Learn how to provide sufficient color contrast](https://dequeuniversity.com/rules/axe/4.9/color-contrast).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/definition-list.js b/core/audits/accessibility/definition-list.js index 0d04aaec1c81..412f7be7eadf 100644 --- a/core/audits/accessibility/definition-list.js +++ b/core/audits/accessibility/definition-list.js @@ -22,7 +22,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'When definition lists are not properly marked up, screen readers may produce ' + 'confusing or inaccurate output. ' + - '[Learn how to structure definition lists correctly](https://dequeuniversity.com/rules/axe/4.8/definition-list).', + '[Learn how to structure definition lists correctly](https://dequeuniversity.com/rules/axe/4.9/definition-list).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/dlitem.js b/core/audits/accessibility/dlitem.js index 41c7edf9ae31..ff7c16c83b0a 100644 --- a/core/audits/accessibility/dlitem.js +++ b/core/audits/accessibility/dlitem.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Definition list items (`
` and `
`) must be wrapped in a ' + 'parent `
` element to ensure that screen readers can properly announce them. ' + - '[Learn how to structure definition lists correctly](https://dequeuniversity.com/rules/axe/4.8/dlitem).', + '[Learn how to structure definition lists correctly](https://dequeuniversity.com/rules/axe/4.9/dlitem).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/document-title.js b/core/audits/accessibility/document-title.js index f1ddb6c59d5d..e779be997927 100644 --- a/core/audits/accessibility/document-title.js +++ b/core/audits/accessibility/document-title.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'The title gives screen reader users an overview of the page, and search ' + 'engine users rely on it heavily to determine if a page is relevant to their search. ' + - '[Learn more about document titles](https://dequeuniversity.com/rules/axe/4.8/document-title).', + '[Learn more about document titles](https://dequeuniversity.com/rules/axe/4.9/document-title).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/duplicate-id-active.js b/core/audits/accessibility/duplicate-id-active.js index 036a8d1a18df..cc2c78d92d15 100644 --- a/core/audits/accessibility/duplicate-id-active.js +++ b/core/audits/accessibility/duplicate-id-active.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if there are any duplicate id HTML attributes on active, focusable elements. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: '`[id]` attributes on active, focusable elements are not unique', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'All focusable elements must have a unique `id` to ensure that they\'re visible to assistive technologies. [Learn how to fix duplicate `id`s](https://dequeuniversity.com/rules/axe/4.8/duplicate-id-active).', + description: 'All focusable elements must have a unique `id` to ensure that they\'re visible to assistive technologies. [Learn how to fix duplicate `id`s](https://dequeuniversity.com/rules/axe/4.9/duplicate-id-active).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/duplicate-id-aria.js b/core/audits/accessibility/duplicate-id-aria.js index 48e6695ac410..c17f0aacdf95 100644 --- a/core/audits/accessibility/duplicate-id-aria.js +++ b/core/audits/accessibility/duplicate-id-aria.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if there are any duplicate ARIA IDs on the page. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA IDs are not unique', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'The value of an ARIA ID must be unique to prevent other instances from being overlooked by assistive technologies. [Learn how to fix duplicate ARIA IDs](https://dequeuniversity.com/rules/axe/4.8/duplicate-id-aria).', + description: 'The value of an ARIA ID must be unique to prevent other instances from being overlooked by assistive technologies. [Learn how to fix duplicate ARIA IDs](https://dequeuniversity.com/rules/axe/4.9/duplicate-id-aria).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/empty-heading.js b/core/audits/accessibility/empty-heading.js index a13f193dcd54..7e2dfdc38c90 100644 --- a/core/audits/accessibility/empty-heading.js +++ b/core/audits/accessibility/empty-heading.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'A heading with no content or inaccessible text prevent screen reader users from ' + 'accessing information on the page\'s structure. ' + - '[Learn more about headings](https://dequeuniversity.com/rules/axe/4.8/empty-heading).', + '[Learn more about headings](https://dequeuniversity.com/rules/axe/4.9/empty-heading).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/form-field-multiple-labels.js b/core/audits/accessibility/form-field-multiple-labels.js index 7a10edc38e9b..f8d2a13179a0 100644 --- a/core/audits/accessibility/form-field-multiple-labels.js +++ b/core/audits/accessibility/form-field-multiple-labels.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if any form fields have multiple label elements. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'Form fields have multiple labels', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'Form fields with multiple labels can be confusingly announced by assistive technologies like screen readers which use either the first, the last, or all of the labels. [Learn how to use form labels](https://dequeuniversity.com/rules/axe/4.8/form-field-multiple-labels).', + description: 'Form fields with multiple labels can be confusingly announced by assistive technologies like screen readers which use either the first, the last, or all of the labels. [Learn how to use form labels](https://dequeuniversity.com/rules/axe/4.9/form-field-multiple-labels).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/frame-title.js b/core/audits/accessibility/frame-title.js index 2280475ccddb..4e69daf04ff1 100644 --- a/core/audits/accessibility/frame-title.js +++ b/core/audits/accessibility/frame-title.js @@ -19,7 +19,7 @@ const UIStrings = { failureTitle: '`` or `