Skip to content

Commit 4f6e9f8

Browse files
oliverdunkAmySteam
andauthored
Apply suggestions from code review
Co-authored-by: amysteamdev <[email protected]>
1 parent e64bb10 commit 4f6e9f8

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

api-samples/readingList/README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,17 @@ This sample demonstrates using the [chrome.readingList](https://developer.chrome
44

55
## Overview
66

7-
Once this extension is installed, clicking this extension's action icon will open an extension page.
7+
The extension's action icon opens a page that allows you to add new items, as well as update or delete existing ones.
88

99
<img src="screenshot.png" height=300 alt="Screenshot showing the chrome.readingList API demo running in Chrome.">
1010

11+
## Running this extension
12+
13+
1. Clone this repository.
14+
2. Load this directory in Chrome as an [unpacked extension](https://developer.chrome.com/docs/extensions/mv3/getstarted/development-basics/#load-unpacked).
15+
3. Click on the action icon.
16+
4. An extension page will open.
17+
1118
## Implementation Notes
1219

1320
Listeners are added for all events, so the table automatically updates when data in the reading list changes.

api-samples/readingList/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ async function updateUI() {
5959
for (const item of items) {
6060
// Use existing row if possible, otherwise create a new one.
6161
const row =
62-
document.querySelector(`[data-url="${item.url}"`) ||
62+
document.querySelector(`[data-url="${item.url}"]`) ||
6363
document.getElementById(TABLE_ITEM_TEMPLATE_ID).content.cloneNode(true)
6464
.children[0];
6565

api-samples/readingList/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "Reading List API Demo",
33
"version": "1.0",
44
"manifest_version": 3,
5-
"description": "Uses the chrome.readingList API to display reading list entries.",
5+
"description": "Uses the chrome.readingList API to display, update and remove reading list entries.",
66
"background": {
77
"service_worker": "sw.js"
88
},

0 commit comments

Comments
 (0)