Skip to content
This repository was archived by the owner on May 30, 2025. It is now read-only.

Commit e2e3691

Browse files
authored
Replace XSSFWorkbook with SXSSFWorkbook (metabase#12521)
1 parent 19e2bcd commit e2e3691

File tree

1 file changed

+3
-2
lines changed
  • src/metabase/query_processor/streaming

1 file changed

+3
-2
lines changed

src/metabase/query_processor/streaming/xlsx.clj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
[i18n :refer [tru]]])
1111
(:import java.io.OutputStream
1212
org.apache.poi.ss.usermodel.Cell
13-
org.apache.poi.xssf.usermodel.XSSFWorkbook))
13+
org.apache.poi.xssf.streaming.SXSSFWorkbook))
1414

1515
(defmethod i/stream-options :xlsx
1616
[_]
@@ -35,7 +35,7 @@
3535
;; TODO -- this is obviously not streaming! SAD!
3636
(defmethod i/streaming-results-writer :xlsx
3737
[_ ^OutputStream os]
38-
(let [workbook (XSSFWorkbook.)
38+
(let [workbook (SXSSFWorkbook.)
3939
sheet (spreadsheet/add-sheet! workbook (tru "Query result"))]
4040
(reify i/StreamingResultsWriter
4141
(begin! [_ {{:keys [cols]} :data}]
@@ -46,4 +46,5 @@
4646

4747
(finish! [_ _]
4848
(spreadsheet/save-workbook-into-stream! os workbook)
49+
(.dispose workbook)
4950
(.close os)))))

0 commit comments

Comments
 (0)