Merge pull request metabase#460 from metabase/incl_dims_in_breakout

agilliland · agilliland · commit a01525d92a5a · 2015-06-08T13:36:25.000-07:00
include fields with "dimension" field_type in our breakout list in query builder
diff --git a/resources/frontend_client/app/explore/explore.services.js b/resources/frontend_client/app/explore/explore.services.js
@@ -36,7 +36,7 @@ ExploreServices.service('CorvusFormGenerator', [function() {
     }
 
     function isDimension(field) {
-        return isDate(field) || isCategory(field);
+        return isDate(field) || isCategory(field) || isInTypes(field.field_type, ['dimension']);
     }
 
 

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ ExploreServices.service('CorvusFormGenerator', [function() {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`function isDimension(field) {`
`39`		`- return isDate(field) \|\| isCategory(field);`
	`39`	`+ return isDate(field) \|\| isCategory(field) \|\| isInTypes(field.field_type, ['dimension']);`
`40`	`40`	`}`
`41`	`41`
`42`	`42`