Merge x.37.5back into master (metabase#14282)

* metabase#11907 Repro: Tooltip should display correct value for unaggregated data [ci skip] (metabase#14102)


Co-authored-by: flamber <[email protected]>

* metabase#11957 Repro: Changing filters shouldn't drop aggregated filter [ci skip] (metabase#14103)

* metabase#13187 Repro: FE should respect (BE) settings for `auto_run_queries` [ci skip] (metabase#14120)

* Mac App build script tweaks

* Defer the parser and its related construction until it's needed (metabase#14133)

Expression parser construction is expensive (mainly due to grammar validation
via Chevrotain's performSelfAnalysis). Thus, instantiating the parsers at the
initialization time will lead to a signifant delay in DOMContentLoaded,
thereby affecting (among others) the embedding performance.

To avoid this, simply defer that step until parsing is really needed
(which is actually far far later, i.e. when the user is using the
notebook).

* Add a clarifying comment regarding parser lazy loading

* Fix metabase#13187: FE should respect settings for `auto_run_queries` on page load (metabase#14121)

Closes metabase#13187

* Remove initial state from `auto_run_queries`

* Assert that `auto_run_queries` is ON by default for sample dataset

This test confirms that toggle works without explicitly setting the initial state to `true`.

* Improve toggle's accessibility

Reference: https://a11y-style-guide.com/style-guide/section-forms.html#kssref-forms-toggles

* Adjust Cypress tests

* metabase#13415 Repro: Visualization type should be respected when entering a question from a dashboard [ci skip] (metabase#14142)

* Fix metabase#13299: Misconfigured "Port" label and input fields (metabase#14134)

Closes metabase#13299

* Add `aria-labelledby` attribute to numeric form fields

* Update affected Cypress tests

* metabase#13175 Repro: Can not do arithmetic in filter expressions (metabase#14155)

* metabase#14193 Repro: Custom column is dropped after removing filter (that comes after aggregation) [ci skip] (metabase#14197)

* Fix 13868 (second try) (metabase#14248)

* Fix 13868

* Unskip Cypress test

* metabase#14255 Repro: CC and table column same name [REGRESSION] [ci skip] (metabase#14267)

* Backport migrations fixups from master (metabase#14276)

* Misc code improvements (metabase#14247)

* Add test-cypress-open-no-backend

* Enable test endpoints for dev

* More are+ test util function to metabase.test

* Improve the way with-temp-defaults are reloaded for models

* Simplify defendpoint macro a bit; convert tests to new style

* Rework a few more tests

* Code cleanup

Co-authored-by: Nemanja Glumac <[email protected]>
Co-authored-by: flamber <[email protected]>
Co-authored-by: Ariya Hidayat <[email protected]>

Author: 4 people

OSX/Metabase/Metabase-Info.plist

@@ -17,11 +17,11 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>0.34.3</string>
+	<string>0.37.2</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>0.34.3</string>
+	<string>0.37.2</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.utilities</string>
 	<key>LSMinimumSystemVersion</key>

bin/lib/sign_update.rb renamed to OSX/bin/sign_update.rb

@@ -8,5 +8,4 @@ cd "$script_directory"
 source "../bin/check-clojure-cli.sh"
 check_clojure_cli
 
-cd OSX/macos_release
 clojure -M -m macos-release $@

OSX/release.sh

@@ -1,7 +1,8 @@
 (ns macos-release.create-dmg
   (:require [macos-release
              [codesign :as codesign]
-             [common :as c]]))
+             [common :as c]]
+            [metabuild-common.core :as u]))
 
 (def ^:private dmg         (c/artifact "Metabase.dmg"))
 (def ^:private temp-dmg    "/tmp/Metabase.dmg")
@@ -10,7 +11,7 @@
 
 (defn- copy-app-to-source-dir! []
   (c/step "Copy app to source dir"
-    (c/delete-file! source-dir)
+    (u/delete-file-if-exists! source-dir)
     (c/create-directory-unless-exists! source-dir)
     (let [source-app (c/assert-file-exists (c/artifact "Metabase.app"))
           dest-app   (str source-dir "/Metabase.app")]
@@ -19,7 +20,7 @@
       (codesign/verify-codesign dest-app))))
 
 (defn- create-dmg-from-source-dir! []
-  (c/delete-file! temp-dmg)
+  (u/delete-file-if-exists! temp-dmg)
   (c/step (format "Create DMG %s from source dir %s" temp-dmg source-dir)
     (c/sh "hdiutil"    "create"
           "-srcfolder" (str (c/assert-file-exists source-dir) "/")
@@ -71,14 +72,14 @@
 
 (defn- add-applications-shortcut! []
   (c/assert-file-exists mounted-dmg)
-  (c/sh "osascript" (c/assert-file-exists (str c/macos-source-dir "/macos_release/addShortcut.scpt"))))
+  (c/sh "osascript" (c/assert-file-exists (u/filename c/macos-source-dir "src" "macos_release" "addShortcut.scpt"))))
 
 (defn- delete-temporary-files-in-dmg!
   "Delete any temporary files that might have creeped in."
   []
   (c/assert-file-exists mounted-dmg)
-  (c/delete-file! (str mounted-dmg "/.Trashes")
-                  (str mounted-dmg "/.fseventsd")))
+  (u/delete-file-if-exists! (str mounted-dmg "/.Trashes")
+                            (str mounted-dmg "/.fseventsd")))
 
 (defn- set-dmg-permissions! []
   (c/sh "chmod" "-Rf" "go-w" (c/assert-file-exists mounted-dmg)))
@@ -88,7 +89,7 @@
 
 (defn- compress-and-copy-dmg!
   []
-  (c/delete-file! dmg)
+  (u/delete-file-if-exists! dmg)
   (c/step (format "Compress DMG %s -> %s" (c/assert-file-exists temp-dmg) dmg)
     (c/sh "hdiutil" "convert" temp-dmg
           "-format" "UDZO"
@@ -98,11 +99,11 @@
 
 (defn- delete-temp-files! []
   (c/step "Delete temp files"
-    (c/delete-file! temp-dmg source-dir)))
+    (u/delete-file-if-exists! temp-dmg source-dir)))
 
 (defn create-dmg! []
   (c/step (format "Create %s" dmg)
-    (c/delete-file! dmg temp-dmg source-dir)
+    (u/delete-file-if-exists! dmg temp-dmg source-dir)
     (copy-app-to-source-dir!)
     (create-dmg-from-source-dir!)
     (with-mounted-dmg [_ temp-dmg]

OSX/src/macos_release/create_dmg.clj

@@ -6,6 +6,7 @@
             [macos-release
              [codesign :as codesign]
              [common :as c]]
+            [metabuild-common.core :as u]
             [pl.danieljanus.tagsoup :as tagsoup])
   (:import [java.io File FileOutputStream OutputStreamWriter]
            java.nio.charset.StandardCharsets))
@@ -17,7 +18,7 @@
 (defn- verify-zip-codesign []
   (c/step (format "Verify code signature of Metabase.app archived in %s" zip-file)
     (let [temp-file "/tmp/Metabase.zip"]
-      (c/delete-file! temp-file)
+      (u/delete-file-if-exists! temp-file)
       (c/sh {:quiet? true}
             "unzip" (c/assert-file-exists zip-file)
             "-d"    temp-file)
@@ -26,7 +27,7 @@
         (codesign/verify-codesign unzipped-app-file)))))
 
 (defn- create-zip-archive! []
-  (c/delete-file! zip-file)
+  (u/delete-file-if-exists! zip-file)
   (c/step (format "Create ZIP file %s" zip-file)
     (c/assert-file-exists (c/artifact "Metabase.app"))
     ;; Use ditto instead of zip to preserve the codesigning -- see https://forums.developer.apple.com/thread/116831
@@ -38,8 +39,8 @@
 
 (defn- generate-file-signature [filename]
   (c/step (format "Generate signature for %s" filename)
-    (let [private-key (c/assert-file-exists (str c/macos-source-dir "/dsa_priv.pem"))
-          script      (c/assert-file-exists (str c/root-directory "/bin/lib/sign_update.rb"))
+    (let [private-key (c/assert-file-exists (u/filename c/macos-source-dir "dsa_priv.pem"))
+          script      (c/assert-file-exists (u/filename c/macos-source-dir "bin" "sign_update.rb"))
           [out]       (c/sh script (c/assert-file-exists filename) private-key)
           signature   (str/trim out)]
       (assert (seq signature))
@@ -89,7 +90,7 @@
          :sparkle/dsaSignature signature}]]]])))
 
 (defn- generate-appcast! []
-  (c/delete-file! appcast-file)
+  (u/delete-file-if-exists! appcast-file)
   (c/step (format "Generate appcast %s" appcast-file)
     (with-open [os (FileOutputStream. (File. appcast-file))
                 w  (OutputStreamWriter. os StandardCharsets/UTF_8)]
@@ -117,7 +118,7 @@
    [:body (release-notes-body)]])
 
 (defn- generate-release-notes! []
-  (c/delete-file! release-notes-file)
+  (u/delete-file-if-exists! release-notes-file)
   (c/step (format "Generate release notes %s" release-notes-file)
     (let [notes (release-notes)]
       (with-open [w (io/writer release-notes-file)]

OSX/src/macos_release/sparkle_artifacts.clj

@@ -8,6 +8,7 @@ const FormInputWidget = ({ placeholder, field }) => (
   <NumericInput
     className="Form-input full"
     placeholder={placeholder}
+    aria-labelledby={`${field.name}-label`}
     {...formDomOnlyProps(field)}
   />
 );

frontend/src/metabase/components/form/widgets/FormNumericInputWidget.jsx

@@ -3,7 +3,12 @@ import React from "react";
 import Toggle from "metabase/components/Toggle";
 
 const FormToggleWidget = ({ field }) => (
-  <Toggle aria-labelledby={`${field.name}-label`} {...field} />
+  <Toggle
+    aria-labelledby={`${field.name}-label`}
+    aria-checked={field.value}
+    role="switch"
+    {...field}
+  />
 );
 
 export default FormToggleWidget;

frontend/src/metabase/components/form/widgets/FormToggleWidget.jsx

@@ -282,7 +282,6 @@ const forms = {
         type: "boolean",
         title: t`Automatically run queries when doing simple filtering and summarizing`,
         description: t`When this is on, Metabase will automatically run queries when users do simple explorations with the Summarize and Filter buttons when viewing a table or chart. You can turn this off if querying this database is slow. This setting doesn’t affect drill-throughs or SQL queries.`,
-        initial: true,
         hidden: !engine,
       },
       {

frontend/src/metabase/entities/databases/forms.js

@@ -1,10 +1,12 @@
-import { parse } from "metabase/lib/expressions/parser";
-import { compile } from "metabase/lib/expressions/compile";
-import { suggest } from "metabase/lib/expressions/suggest";
-import { syntax } from "metabase/lib/expressions/syntax";
-
 // combine compile/suggest/syntax so we only need to parse once
 export function processSource(options) {
+  // Lazily load all these parser-related stuff, because parser construction is expensive
+  // https://github.com/metabase/metabase/issues/13472
+  const parse = require("./parser").parse;
+  const compile = require("./compile").compile;
+  const suggest = require("./suggest").suggest;
+  const syntax = require("./syntax").syntax;
+
   const { source, targetOffset } = options;
 
   let expression;

frontend/src/metabase/lib/expressions/process.js

@@ -22,10 +22,11 @@ export const BackendResource = createSharedResource("BackendResource", {
   create({ dbKey = DEFAULT_DB_KEY }) {
     const dbFile = getDbFile();
     const absoluteDbKey = dbKey ? __dirname + dbKey : dbFile;
-    if (process.env["E2E_HOST"] && dbKey === DEFAULT_DB_KEY) {
+    const e2eHost = process.env["E2E_HOST"];
+    if (e2eHost) {
       return {
         dbKey: absoluteDbKey,
-        host: process.env["E2E_HOST"],
+        host: e2eHost,
         process: { kill: () => {} },
       };
     } else {