Remove redundant stuff

Author: Glyphack

typechecker/src/build.rs

@@ -1,7 +1,7 @@
 use std::{
     collections::{HashMap, HashSet},
     path::{Path, PathBuf},
-    sync::{Arc, RwLockWriteGuard},
+    sync::Arc,
 };
 use tracing::{span, Level};
 use tracing_subscriber::EnvFilter;

typechecker/src/file.rs

@@ -11,8 +11,8 @@ use parser::{ast, get_row_col_position, parser::parser::Parser};
 use std::sync::atomic::Ordering;
 
 use crate::build::ResolvedImports;
+use crate::symbol_table;
 use crate::{diagnostic::Position, semantic_analyzer::SemanticAnalyzer, symbol_table::SymbolTable};
-use crate::{get_module_name, symbol_table};
 
 #[derive(Clone, Debug)]
 pub enum ImportKinds<'a> {
@@ -25,7 +25,6 @@ pub enum ImportKinds<'a> {
 #[derive(Clone, Debug)]
 pub struct EnderpyFile {
     pub id: symbol_table::Id,
-    pub module: String,
     // if this source is found by following an import
     pub followed: bool,
     pub path: Arc<PathBuf>,
@@ -58,7 +57,6 @@ impl<'a> EnderpyFile {
     pub fn new(path: PathBuf, followed: bool) -> Self {
         let source =
             std::fs::read_to_string(&path).unwrap_or_else(|_| panic!("cannot read file {path:?}"));
-        let module = get_module_name(&path);
 
         let mut parser = Parser::new(&source);
         let parse_result = catch_unwind(AssertUnwindSafe(|| parser.parse()));
@@ -71,7 +69,7 @@ impl<'a> EnderpyFile {
                 panic!("Cannot parse file : {path:?}");
             }
         };
-        let line_starts = parser.lexer.line_starts.clone();
+        let line_starts = parser.lexer.line_starts;
 
         let id = if path.ends_with("builtins.pyi") {
             symbol_table::Id(0)
@@ -84,14 +82,10 @@ impl<'a> EnderpyFile {
             source,
             line_starts,
             followed,
-            module,
             tree,
             path: Arc::new(path),
         }
     }
-    pub fn module_name(&self) -> String {
-        self.module.clone()
-    }
 
     pub fn path(&self) -> PathBuf {
         self.path.to_path_buf()

typechecker/src/semantic_analyzer.rs

@@ -110,8 +110,7 @@ impl<'a> SemanticAnalyzer<'a> {
                 }
             }
             Expression::Attribute(a) => {
-                let member_access_info =
-                    get_member_access_info(&self.symbol_table, &self.file, &a.value);
+                let member_access_info = get_member_access_info(&self.symbol_table, &a.value);
                 let symbol_flags = if member_access_info.is_some_and(|x| x) {
                     SymbolFlags::INSTANCE_MEMBER
                 } else {
@@ -122,13 +121,8 @@ impl<'a> SemanticAnalyzer<'a> {
                     self.symbol_table.current_scope().kind.as_function()
                 {
                     // TODO: some python usual names to be interned
-                    if intern_lookup(function_def.name) == "__init__"
+                    intern_lookup(function_def.name) == "__init__"
                         || intern_lookup(function_def.name) == "__new__"
-                    {
-                        true
-                    } else {
-                        false
-                    }
                 } else {
                     false
                 };
@@ -841,7 +835,6 @@ pub struct MemberAccessInfo {}
 // or true if the member is an instance member and false if it is a class member
 pub fn get_member_access_info(
     symbol_table: &SymbolTable,
-    file: &EnderpyFile,
     value: &parser::ast::Expression,
     //TODO: This is option to use the `?` operator. Remove it
 ) -> Option<bool> {

typechecker/src/type_evaluator.rs

@@ -327,7 +327,7 @@ impl<'a> TypeEvaluator<'a> {
                 // Case 1
                 // This is self or cls
                 let file = &self.build_manager.files.get(&symbol_table.id).unwrap();
-                if get_member_access_info(symbol_table, file, &a.value).is_some() {
+                if get_member_access_info(symbol_table, &a.value).is_some() {
                     let enclosing_parent_class = symbol_table.get_enclosing_class_scope();
                     if let Some(enclosing_parent_class) = enclosing_parent_class {
                         let symbol_table_node =
@@ -1604,7 +1604,7 @@ impl<'a> TypeEvaluator<'a> {
     ) -> PythonType {
         // TODO: handle default values
 
-        let name = f.function_node.name.clone();
+        let name = f.function_node.name;
         let signature =
             self.get_function_signature(&f.function_node.args, symbol_table, arguments_scope_id);
         let return_type =
@@ -1634,7 +1634,7 @@ impl<'a> TypeEvaluator<'a> {
         scope_id: u32,
     ) -> PythonType {
         let arguments = f.function_node.args.clone();
-        let name = f.function_node.name.clone();
+        let name = f.function_node.name;
         let signature = self.get_function_signature(&f.function_node.args, symbol_table, scope_id);
         let return_type = f
             .function_node