Added rate limiter for all APIs #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You've made your first pull request - awesome! Let's collaborate to make this project even better
If you're fixing a bug, please refer to the issue number in the description.
If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.
Mustafiz04
reviewed
Oct 22, 2024
Comment on lines
+1
to
+34
| // Rate Limiting using Token bucket algorithm | ||
|
|
||
| // Maximum number of requests allowed in a given time frame | ||
| const REQUEST_LIMIT = 5; | ||
|
|
||
| // Time frame in milliseconds | ||
| const WINDOW_SIZE = 10000; | ||
|
|
||
| // Initialize with REQUEST_LIMIT number of tokens | ||
| const tokens = Array(REQUEST_LIMIT).fill(1); | ||
|
|
||
| var time = new Date().getTime(); | ||
|
|
||
| export const rateLimiter = (req, res, next) => { | ||
| if (tokens.length && new Date().getTime() - time < WINDOW_SIZE) { | ||
| tokens.pop(); | ||
| next(); | ||
| } else { | ||
| if (new Date().getTime() - time >= WINDOW_SIZE) { | ||
| const len = tokens.length; | ||
| for (let i = 0; i < 5 - len; i++) { | ||
| tokens.push(1); | ||
| } | ||
| time = new Date().getTime(); | ||
| rateLimiter(req, res, next); | ||
| } else { | ||
| res.status(429).json({ | ||
| message: `You have exceeded the ${REQUEST_LIMIT} requests in ${WINDOW_SIZE} ms limit !! , ${ | ||
| new Date().getTime() - time | ||
| }`, | ||
| status: 429, | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can't we use some library that provides a lot more functionality and use build that ?
Basically RateLimiter class with multiple configurations like algorithm, different rate limit, and so on
There was a problem hiding this comment.
Understood the requirement. We can I guess. Let me work on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Using the token bucket algorithm, I have added the rate Limit to all the endpoints.
Modify these constants accordingly
` const REQUEST_LIMIT = 5;
// Time frame in milliseconds
const WINDOW_SIZE = 10000; `
Note: There are other approaches, like using Redis or a 3rd party library. Currently, this approach is memory efficient.
Improvement: We could limit the number of requests made to the server for each user individually using their IP address or user ID or token.