Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding issues in translation files #65

Open
juancorr opened this issue Mar 5, 2020 · 6 comments
Open

Encoding issues in translation files #65

juancorr opened this issue Mar 5, 2020 · 6 comments

Comments

@juancorr
Copy link
Contributor

juancorr commented Mar 5, 2020

Dataverse v4.19 has some translation files with characters in iso-8859-1 or utf-8 without the escape way . This characters are not right displayed in Dataverse. These files are:

en_US/astrophysics.properties: text/plain; charset=utf-8
en_US/citation.properties: text/plain; charset=iso-8859-1
en_US/astrophysics.properties: text/plain; charset=utf-8
en_US/customDigaai.properties: text/plain; charset=iso-8859-1
en_US/geospatial.properties: text/plain; charset=iso-8859-1
fr_CA/journal_fr.properties: text/plain; charset=iso-8859-1
fr_CA/BuiltInRoles_fr.properties: text/plain; charset=iso-8859-1
fr_CA/astrophysics_fr.properties: text/plain; charset=iso-8859-1
fr_CA/Bundle_fr.properties: text/plain; charset=unknown-8bit
fr_CA/socialscience_fr.properties: text/plain; charset=iso-8859-1
fr_CA/ValidationMessages_fr.properties: text/plain; charset=iso-8859-1
fr_CA/MimeTypeDisplay_fr.properties: text/plain; charset=iso-8859-1
fr_CA/geospatial_fr.properties: text/plain; charset=iso-8859-1
fr_CA/citation_fr.properties: text/plain; charset=iso-8859-1
fr_CA/biomedical_fr.properties: text/plain; charset=iso-8859-1
fr_CA/Bundle_fr.properties: text/plain; charset=unknown-8bit
fr_CA/MimeTypeFacets_fr.properties: text/plain; charset=iso-8859-1
pt_BR/citation_br.properties: text/plain; charset=iso-8859-1
pt_BR/BuiltInRoles_br.properties: text/plain; charset=iso-8859-1
pt_BR/Bundle_br.properties: text/plain; charset=iso-8859-1

@kaitlinnewson
Copy link
Collaborator

Hi @juancorr, do you have any screenshots or more information about where you see these issues in the UI? I've been reviewing our local install of 4.19 in English and French and haven't seen any characters with display issues so far.

@juancorr
Copy link
Contributor Author

juancorr commented May 6, 2020 via email

@juancorr
Copy link
Contributor Author

juancorr commented May 6, 2020

@kaitlinnewson, I have replied from my e-mail and screenshots are not shown. This is the Screenshot from the Bundle_fr.properties file
imagen

and this is the screenshot from the Astronomy Spectral Resolution field in English
imagen

mhvezina added a commit to BibNumUMontreal/dataverse-language-packs that referenced this issue May 8, 2020
- main translation for new/updated variables ;
- I took the opportunity to fix a few occurrences where double quotation
marks (« »), alongside with nonbreaking spaces should have been used
instead of (" ");
- correction of one faulty occurrence of "Roles" for "Rôles" ;
- I changed the en dash (dataset.widgets.editAdvanced.tip) for an
explicit  Unicode character with /nxxxx notation (to prevent this error
maybe(?):
GlobalDataverseCommunityConsortium#65 (comment)).
@mhvezina
Copy link
Collaborator

mhvezina commented May 8, 2020

Hi @juancorr
I replaced the en dash (dataset.widgets.editAdvanced.tip) within the fr_CA/Bundle_fr.properties file (version 4.20) for an explicit Unicode character with /nxxxx notation. (eeb421c). Is that better?

@juancorr
Copy link
Contributor Author

juancorr commented May 8, 2020 via email

@JayanthyChengan
Copy link
Collaborator

Thanks @juancorr and @mhvezina .

I submitted PR IQSS/dataverse#6904
after correcting datasetfieldtype.resolution.Spectral.description entry in the
astrophysics.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants