Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use euclidean distance to propagate NaNs in interp_points? #603

Open
rhugonnet opened this issue Sep 3, 2024 · 0 comments
Open

Use euclidean distance to propagate NaNs in interp_points? #603

rhugonnet opened this issue Sep 3, 2024 · 0 comments
Labels
enhancement Feature improvement or request question Further information is requested

Comments

@rhugonnet
Copy link
Contributor

rhugonnet commented Sep 3, 2024

Currently we use a series of binary_dilation to propagate NaNs to a certain pixel distance in interp_points, but this seems to match the L1 norm (abs(dX) + abs(dY)) and not a classic euclidean distance.
Should we change this scheme to an euclidean distance instead? (same calculation as Raster.proximity())
Would this better match the reason for the nodata propagation? (=size of interpolation kernels for linear/cubic/quintic methods)

See original mention below:

Originally posted by @rhugonnet in #560 (comment)

@rhugonnet rhugonnet added enhancement Feature improvement or request question Further information is requested labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant