Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in detecting donations on ETC and Solana dev nets on the Staging #1681

Closed
ae2079 opened this issue Jul 14, 2024 · 10 comments
Closed

bug in detecting donations on ETC and Solana dev nets on the Staging #1681

ae2079 opened this issue Jul 14, 2024 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@ae2079
Copy link
Contributor

ae2079 commented Jul 14, 2024

          @divine-comedian @ae2079 

dn

I have made multiple donations in Ethereum Classic Mordor Network, although they were successful, they all show pending here and also does not reflect in the Analytics board.

Originally posted by @LatifatAbdullahi in Giveth/analytics-dashboard#9 (comment)

@ae2079
Copy link
Contributor Author

ae2079 commented Jul 14, 2024

@ae2079 ae2079 self-assigned this Jul 14, 2024
@ae2079
Copy link
Contributor Author

ae2079 commented Jul 14, 2024

and maybe related to these issues:
Giveth/giveth-dapps-v2#4371
Giveth/giveth-dapps-v2#4368

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jul 15, 2024
@divine-comedian divine-comedian moved this from New Issues to Product Backlog in All-Devs Jul 15, 2024
@divine-comedian divine-comedian added the bug Something isn't working label Jul 15, 2024
@divine-comedian
Copy link
Collaborator

We should retest the feature requirements for Giveth/analytics-dashboard#9 on ETC mordor and solana devnet once this issue is fixed.

@ae2079
Copy link
Contributor Author

ae2079 commented Jul 21, 2024

We should retest the feature requirements for Giveth/analytics-dashboard#9 on ETC mordor and solana devnet once this issue is fixed.

the bug related to Solana dev net is because of using test net id (102) instead of devnet id (103), and now it is compatible with the backend and fixed

@divine-comedian
Copy link
Collaborator

We should retest the feature requirements for Giveth/analytics-dashboard#9 on ETC mordor and solana devnet once this issue is fixed.

the bug related to Solana dev net is because of using test net id (102) instead of devnet id (103), and now it is compatible with the backend and fixed

@ae2079 - did you also discover why ETC mordor was not working?

@ae2079
Copy link
Contributor Author

ae2079 commented Jul 21, 2024

We should retest the feature requirements for Giveth/analytics-dashboard#9 on ETC mordor and solana devnet once this issue is fixed.

the bug related to Solana dev net is because of using test net id (102) instead of devnet id (103), and now it is compatible with the backend and fixed

@ae2079 - did you also discover why ETC mordor was not working?

no, I'm on it

@ae2079
Copy link
Contributor Author

ae2079 commented Jul 22, 2024

@divine-comedian
The bug on not detecting Mordor ETC donations was related to not setting environment variables, and as I don't have access to change the deployments, asked @RamRamez to set the correct value of them, and now by adding a default value for Mordor ETC URL, the bug is fixed and now we can donate to projects with etc mordor on staging @maryjaf @LatifatAbdullahi
(I donated to this project successfully: https://staging.giveth.io/project/teach-music-to-children?tab=donations )

@ae2079 ae2079 moved this from Product Backlog to In Progress in All-Devs Jul 22, 2024
@ae2079 ae2079 moved this from In Progress to QA in All-Devs Jul 22, 2024
@divine-comedian
Copy link
Collaborator

divine-comedian commented Jul 22, 2024

Ok thanks!

@LatifatAbdullahi - this was related to when testing the analytics features on those two devnets.

to test

  1. make donations using ETC mordor and solana devnet
  2. ensure donations show as success and not pending if the donation was successful.(might take up to 5 mins to confirm)
  3. check https://staging.stats.giveth.io/ to ensure donations appear there as well - donation count, total usd donation value (if token donated had a tracked price)

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Jul 22, 2024

@divine-comedian @ae2079

Test Update

-make donations using ETC mordor - Pass
-make donations using solana devnet - Pass
-ensure donations with ETC Mordor show as success and not pending if the donation was successful - Pass
-ensure donations with Solana devnet show as success and not pending if the donation was successful - Pass

Analytics
ETC Mordor

  • Project count - Pass
  • Donors count - Pass
  • Donations count - Pass
  • Total donations in USD - Pass

Solana Devnet

  • Project count - Pass
  • Donors count - Pass
  • Donations count - Pass
  • Total donations in USD - Pass

image

The staging Analyticst throws this error ocassionally

image

@LatifatAbdullahi
Copy link

@divine-comedian

Although this issue is fixed, I found two new issues with donating with Solana devnet

#1710
#1711

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants