Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Add toggle to switch between open and closed issues/PRs on repos #374

Open
rnystrom opened this issue Sep 22, 2017 · 12 comments · May be fixed by #2687
Open

Add toggle to switch between open and closed issues/PRs on repos #374

rnystrom opened this issue Sep 22, 2017 · 12 comments · May be fixed by #2687
Labels
👍 feature approved Features approved for implementation

Comments

@rnystrom
Copy link
Member

Probably just put a unit at the top of the list?

@rnystrom rnystrom added 🆕 feature request A feature being requested to be added, not yet approved mid labels Sep 22, 2017
@Sherlouk
Copy link
Member

Relates to #287

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Oct 17, 2018

Is there any roadmap to add a open/closed toggle. #287 is closed itself

@BasThomas
Copy link
Collaborator

I think we can close this, unless we want to revisit the way we do this soon. Closing for now; feel free to reopen if anyone feels this needs improvement.

@ijm8710
Copy link

ijm8710 commented Oct 17, 2018

@rnystrom what were your thoughts on the value of tabbed or toggle options between open/close. As is I have to retype the word closed on the default open identifier. Saw in a chain you intentionally leaned primitive to start, but curious if you see value to polishing that or if you prefer to keep as is.

@rnystrom
Copy link
Member Author

Ya I’d love at the very least a form or picker to make this easier. Right now it works but you have to know how to do all the filters.

It’d be cool to have like a filter icon/button in the bar. Tap it and we show a context menu form with all the options where you can select and enter all sorts of stuff (labels, status, etc) and maybe a link to GitHub search documentation for more advanced stuff.

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Oct 17, 2018

@rnystrom can we reopen this then, or merge if there’s an active ticket :)

@Huddie
Copy link
Collaborator

Huddie commented Mar 11, 2019

#2679 has my design suggestion.
I think it’s a good easy start.

GitHawk Upload by Huddie

@BasThomas, thoughts on this design? Possibly alternatives?

Sent with GitHawk

@BasThomas
Copy link
Collaborator

I like it (and your handwriting). Not sure if that works with a standard UISearchController however. Can you take a stab at this in code and see what it'd look like?

If that doesn't work, what could be an alternative?

@Huddie
Copy link
Collaborator

Huddie commented Mar 12, 2019

I’ll try to code it up and think of alternatives as well. Not sure of a good alt. that doesn’t take up real estate

Sent with GitHawk

@BasThomas
Copy link
Collaborator

Yeah, it would then quickly take up real estate. I really like the current sketch, but that would also take away quite a size from the search bar horizontally... 🤷‍♂️

@Huddie
Copy link
Collaborator

Huddie commented Mar 12, 2019

That’s true but no more is:open necessary which opens up some text. I guess we’d have to see could be it takes up too much space

Sent with GitHawk

@Huddie Huddie linked a pull request Mar 13, 2019 that will close this issue
@Huddie
Copy link
Collaborator

Huddie commented Mar 13, 2019

@BasThomas turns out is not a SearchBarController :D lucky me. Just another cell, easy to manipulate. Check out #2687

@Huddie Huddie added 👍 feature approved Features approved for implementation and removed 🆕 feature request A feature being requested to be added, not yet approved labels Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
👍 feature approved Features approved for implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants