ext/standard/head.c: use RETURN_BOOL() when possible

Girgias · Girgias · commit 2807c368ce0d · 2025-11-29T14:58:49.000Z
diff --git a/ext/standard/head.c b/ext/standard/head.c
@@ -260,11 +260,7 @@ static void php_setcookie_common(INTERNAL_FUNCTION_PARAMETERS, bool is_raw)
 		}
 	}
 
-	if (php_setcookie(name, value, expires, path, domain, secure, httponly, samesite, partitioned, !is_raw) == SUCCESS) {
-		RETVAL_TRUE;
-	} else {
-		RETVAL_FALSE;
-	}
+	RETVAL_BOOL(php_setcookie(name, value, expires, path, domain, secure, httponly, samesite, partitioned, !is_raw) == SUCCESS);
 
 	if (options) {
 cleanup:
@@ -328,11 +324,7 @@ PHP_FUNCTION(headers_sent)
 		break;
 	}
 
-	if (SG(headers_sent)) {
-		RETURN_TRUE;
-	} else {
-		RETURN_FALSE;
-	}
+	RETURN_BOOL(SG(headers_sent));
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -260,11 +260,7 @@ static void php_setcookie_common(INTERNAL_FUNCTION_PARAMETERS, bool is_raw)`
`260`	`260`	`}`
`261`	`261`	`}`
`262`	`262`
`263`		`- if (php_setcookie(name, value, expires, path, domain, secure, httponly, samesite, partitioned, !is_raw) == SUCCESS) {`
`264`		`- RETVAL_TRUE;`
`265`		`- } else {`
`266`		`- RETVAL_FALSE;`
`267`		`- }`
	`263`	`+ RETVAL_BOOL(php_setcookie(name, value, expires, path, domain, secure, httponly, samesite, partitioned, !is_raw) == SUCCESS);`
`268`	`264`
`269`	`265`	`if (options) {`
`270`	`266`	`cleanup:`
`@@ -328,11 +324,7 @@ PHP_FUNCTION(headers_sent)`
`328`	`324`	`break;`
`329`	`325`	`}`
`330`	`326`
`331`		`- if (SG(headers_sent)) {`
`332`		`- RETURN_TRUE;`
`333`		`- } else {`
`334`		`- RETURN_FALSE;`
`335`		`- }`
	`327`	`+ RETURN_BOOL(SG(headers_sent));`
`336`	`328`	`}`
`337`	`329`	`/* }}} */`
`338`	`330`