Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic detector-panel removal #169

Open
GilesStrong opened this issue Dec 12, 2022 · 1 comment
Open

Automatic detector-panel removal #169

GilesStrong opened this issue Dec 12, 2022 · 1 comment
Assignees
Labels
Detectors Issue affects the detectors enhancement New feature or request medium priority Should be fixed soon, but doesn't disastrously impact project Optimisation Issue affects the optimisation of the detector

Comments

@GilesStrong
Copy link
Owner

 ## Problem

The optimisation will sometimes try to minimiser some panels, in order to assign their budget to other, more useful panels, however, this can lead problems, e.g. ScatterBatch._filter_scatters will remove any muons with at least one high-uncertainty hit, i.e. all muons get removed.
Example:

Screenshot 2022-12-12 at 11 56 48

Potential solution

A callback that automatically removes panels. This could trigger on e.g.

  • once their scaled x or y span drops below a fixed threshold
  • if the number of filtered muons exceeds a threshold (absolute or relative to batch size)
@GilesStrong GilesStrong added enhancement New feature or request medium priority Should be fixed soon, but doesn't disastrously impact project Optimisation Issue affects the optimisation of the detector Detectors Issue affects the detectors labels Dec 12, 2022
@GilesStrong GilesStrong self-assigned this Dec 12, 2022
@GilesStrong
Copy link
Owner Author

Potentially this could also be caused by an anomalous gradient making one of the panels jump in assigned budget; may need a step-limiting callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Detectors Issue affects the detectors enhancement New feature or request medium priority Should be fixed soon, but doesn't disastrously impact project Optimisation Issue affects the optimisation of the detector
Projects
None yet
Development

No branches or pull requests

1 participant