Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary orientation of Volume layers in Volume.draw #162

Open
vischia opened this issue Dec 2, 2022 · 0 comments
Open

Arbitrary orientation of Volume layers in Volume.draw #162

vischia opened this issue Dec 2, 2022 · 0 comments
Assignees
@vischia
Labels
Detectors Issue affects the detectors Functionality Issue adds to the functionality of the package Generalisation Issue affects the generalisation of the package good first issue Good for newcomers low priority Should be fixed eventually, but isn't urgent

Comments

@vischia
Copy link
Collaborator

vischia commented Dec 2, 2022

At the moment, Volume.draw works only for horizontal layers.

It would be good to modify it to draw arbitrarily oriented layers, for the future.

The only technical issue preventing this is that currently the layers have xyz placement but only xy spans. If all layer/panel classes returned xyz placement and xyz span, this could be generalized to arbitrarily oriented panels/layers in an Euclidean space.

Requires: changing the interface of layers/panels significantly, to return also a z span, and adapt the code to accept the new interface.
@vischia vischia self-assigned this Dec 2, 2022
@vischia vischia added good first issue Good for newcomers low priority Should be fixed eventually, but isn't urgent Generalisation Issue affects the generalisation of the package Functionality Issue adds to the functionality of the package Detectors Issue affects the detectors labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vischia vischia

Labels
Detectors Issue affects the detectors Functionality Issue adds to the functionality of the package Generalisation Issue affects the generalisation of the package good first issue Good for newcomers low priority Should be fixed eventually, but isn't urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vischia