Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancier transparencies in Volume.draw #161

Open
vischia opened this issue Dec 2, 2022 · 1 comment
Open

Fancier transparencies in Volume.draw #161

vischia opened this issue Dec 2, 2022 · 1 comment
Assignees
Labels
Functionality Issue adds to the functionality of the package good first issue Good for newcomers low priority Should be fixed eventually, but isn't urgent

Comments

@vischia
Copy link
Collaborator

vischia commented Dec 2, 2022

Currently, the passive layers are painted as four opaque (alpha=1) blocks. It would be nice if the back walls were opaque and the front ones were semitransparent.

This requires passing, in Volume.draw, the tensors of vertices of the walls as two separate groups with different alpha.

Bonus feature: when the semitransparency is implemented, draw additional walls to mark the individual voxels (not sure if this is confusing to the eye, but I have seen nice examples around so it should be doable).

@vischia vischia self-assigned this Dec 2, 2022
@vischia vischia added good first issue Good for newcomers low priority Should be fixed eventually, but isn't urgent Functionality Issue adds to the functionality of the package labels Dec 2, 2022
@vischia
Copy link
Collaborator Author

vischia commented Dec 2, 2022

Questionable. "front" and "back" walls are based on a specific view. If the users uses the %matplotlib notebook magic to rotate the figure, this functionality can make things ugly.

It's better to always have all the passive layer walls transparent (but more opaque than detector layers), and then matplotlib will take care of the transparency in rotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality Issue adds to the functionality of the package good first issue Good for newcomers low priority Should be fixed eventually, but isn't urgent
Projects
None yet
Development

No branches or pull requests

1 participant