Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGeant model not yet included in tests against Geant data #133

Open
GilesStrong opened this issue Sep 2, 2022 · 2 comments
Open

PGeant model not yet included in tests against Geant data #133

GilesStrong opened this issue Sep 2, 2022 · 2 comments
Labels
medium priority Should be fixed soon, but doesn't disastrously impact project Simulation Issue affects the accuracy of the generation or scattering simulation Tests Issue affect repo testing

Comments

@GilesStrong
Copy link
Owner

PGeant model doesn't model the bulk of scatterings as well as the PDG model, and is currently excluded from the integration tests comparing the geant distributions to the scatter models (tests require a 2sample Kolmagorov Smirnov test with p-value greater than 0.01 in the 68th percentile of the absolute value of the distribution).
Either we improve the PGeant model, or relax the tests given that the PGeant model is expected to better model the tails of the scatter distributions.
See also issue #132

@GilesStrong GilesStrong added medium priority Should be fixed soon, but doesn't disastrously impact project Simulation Issue affects the accuracy of the generation or scattering simulation Tests Issue affect repo testing labels Sep 2, 2022
@giamman
Copy link
Collaborator

giamman commented Sep 2, 2022

At least ad interim, a way to relax the tests could be to restrict the comparison to the bulk. Does that sound meaningful?

@GilesStrong
Copy link
Owner Author

@giamman Yes, that's currently what I have set up: The tests only check that the bulk is well modelled https://github.com/GilesStrong/mode_muon_tomography/blob/main/tests/test_scattering.py#L228-L248, although KS tests are computed on also the full range and 95th percentile range.
Even so, the PGeant doesn't model the bulk well enough to pass the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Should be fixed soon, but doesn't disastrously impact project Simulation Issue affects the accuracy of the generation or scattering simulation Tests Issue affect repo testing
Projects
None yet
Development

No branches or pull requests

2 participants