Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check usage of volumes centres and edges, and make explicit their dimensions #125

Open
GilesStrong opened this issue Jul 28, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation invalid This doesn't seem right medium priority Should be fixed soon, but doesn't disastrously impact project

Comments

@GilesStrong
Copy link
Owner

GilesStrong commented Jul 28, 2022

Volume.build_edges produces a tensor of corner coordinates for voxels in the volume, and Volume.centres is the centre coordinates of the each voxel. These are in (x,y,z) form. However in many locations in the code, e.g. during volume inference, or returning the voxel layer from volumes, the form is (z,x,y).

  • We should check the code to make sure the tensors are permuted or reshaped correctly.
  • We should improve the names and APIs to make it clearer to users and devs what shapes are expected/returned.
@GilesStrong GilesStrong added documentation Improvements or additions to documentation invalid This doesn't seem right medium priority Should be fixed soon, but doesn't disastrously impact project labels Jul 28, 2022
@GilesStrong GilesStrong added this to To do (Essential) in Publication 1: Detector Optimisation via automation Jul 28, 2022
@GilesStrong GilesStrong added this to To do (Essential) in Publication 2: Inference comparison via automation Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation invalid This doesn't seem right medium priority Should be fixed soon, but doesn't disastrously impact project
Development

No branches or pull requests

1 participant