Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a physical detector interpretation to DetectorHeatMap and rethink the cost computation #112

Open
GilesStrong opened this issue May 24, 2022 · 0 comments
Open

Add a physical detector interpretation to DetectorHeatMap and rethink the cost computation #112

GilesStrong opened this issue May 24, 2022 · 0 comments
Labels
Detectors Issue affects the detectors low priority Should be fixed eventually, but isn't urgent Realism Issue affects what would actually be possible in application

Comments

@GilesStrong
Copy link
Owner

Currently it is unclear how the GMM learnt by DetectorHeatMap can be turned into physical detectors, this needs to be added.
This should also feed into the cost calculation; the cost currently uses the mean of the sigmas of the GMM, rather than the sum (I understand this is for optimisation purposes, but it's unclear if the cost can then truly be measured in currency units). Additionally cost ignores the normalisation of the GMM PDF.
@GilesStrong GilesStrong added low priority Should be fixed eventually, but isn't urgent Realism Issue affects what would actually be possible in application Detectors Issue affects the detectors labels May 24, 2022
@GilesStrong GilesStrong mentioned this issue May 24, 2022
Open
@GilesStrong GilesStrong mentioned this issue Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Detectors Issue affects the detectors low priority Should be fixed eventually, but isn't urgent Realism Issue affects what would actually be possible in application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GilesStrong