Merge pull request #173 from GetStream/feature/uni-128-fix-subscribetotracksasync-null-exception

Try fix SubscribeToTracksAsync NullReferenceException

Author: sierpinskid

Assets/Samples/Stream Video & Audio Chat SDK/0.8.8.meta renamed to Assets/Samples/Stream Video & Audio Chat SDK/0.8.10.meta

@@ -536,6 +536,7 @@ private void ClearSession()
 
             ActiveCall = null;
             CallState = CallingState.Unknown;
+            _httpClient = null;
 
             _trackSubscriptionRequested = false;
             _trackSubscriptionRequestInProgress = false;
@@ -585,10 +586,11 @@ private void TryExecuteSubscribeToTracks()
         /// </summary>
         private async Task SubscribeToTracksAsync()
         {
-            if (ActiveCall.Participants == null || !ActiveCall.Participants.Any())
+            if (ActiveCall?.Participants == null || !ActiveCall.Participants.Any())
             {
 #if STREAM_DEBUG_ENABLED
-                _logs.Error($"{nameof(SubscribeToTracksAsync)} Ignored - No participants in the call to subscribe tracks for");
+                _logs.Error(
+                    $"{nameof(SubscribeToTracksAsync)} Ignored - No participants in the call to subscribe tracks for");
 #endif
 
                 return;
@@ -624,7 +626,7 @@ private async Task SubscribeToTracksAsync()
                 return;
             }
 
-            if (response.Error != null)
+            if (response?.Error != null)
             {
                 _logs.Error(response.Error.Message);
             }
@@ -639,6 +641,12 @@ private IEnumerable<TrackSubscriptionDetails> GetDesiredTracksDetails()
 
             foreach (var participant in ActiveCall.Participants)
             {
+                if (participant == null)
+                {
+                    _logs.Error("Cannot subscribe to tracks - participant is null");
+                    continue;
+                }
+
                 if (participant.IsLocalParticipant)
                 {
                     continue;
@@ -652,9 +660,16 @@ private IEnumerable<TrackSubscriptionDetails> GetDesiredTracksDetails()
                     //This was before changing the IUpdateableFrom<CallParticipantResponseInternalDTO, StreamVideoCallParticipant>.UpdateFromDto
                     //to extract UserId from User obj
 
+                    var userId = GetUserId(participant);
+                    if (string.IsNullOrEmpty(userId))
+                    {
+                        _logs.Error($"Cannot subscribe to {trackType} - participant UserId is null or empty. SessionID: {participant.SessionId}");
+                        continue;
+                    }
+
                     yield return new TrackSubscriptionDetails
                     {
-                        UserId = GetUserId(participant),
+                        UserId = userId,
                         SessionId = participant.SessionId,
                         TrackType = trackType,
                         Dimension = requestedVideoResolution.ToVideoDimension()
@@ -1051,8 +1066,15 @@ private void OnSfuDominantSpeakerChanged(DominantSpeakerChanged dominantSpeakerC
         private void OnSfuWebSocketOnError(SfuError obj)
         {
             _sfuTracer?.Trace(PeerConnectionTraceKey.SfuError, obj);
+            if (CallState == CallingState.Offline)
+            {
+                return;
+            }
+
             _logs.Error(
                 $"Sfu Error - Code: {obj.Error_.Code}, Message: {obj.Error_.Message}, ShouldRetry: {obj.Error_.ShouldRetry}");
+
+            //StreamTODO: add event here
         }
 
         private void OnSfuPinsUpdated(PinsChanged pinsChanged)
@@ -1148,6 +1170,15 @@ private async Task<TResponse> RpcCallAsync<TRequest, TResponse>(TRequest request
         {
             //StreamTodo: use rpcCallAsync.GetMethodInfo().Name; instead debugRequestName
 
+            if (_httpClient == null)
+            {
+                var errorMsg
+                    = $"[RPC Call: {debugRequestName}] Failed - Attempted to execute RPC call but HttpClient is not yet initialized. " +
+                      $"CallState: {CallState}, ActiveCall: {ActiveCall != null}, SessionId: {SessionId ?? "null"}";
+                _logs.Error(errorMsg);
+                throw new InvalidOperationException(errorMsg);
+            }
+
             var skipTracing = debugRequestName == nameof(GeneratedAPI.SendStats);
 
             // Trace the RPC request (except SendStats to avoid noise)