Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dea_tools.classification functions to use odc.geo #1076

Open
robbibt opened this issue Jun 15, 2023 · 1 comment
Open

Refactor dea_tools.classification functions to use odc.geo #1076

robbibt opened this issue Jun 15, 2023 · 1 comment
Assignees

Comments

@robbibt
Copy link
Member

robbibt commented Jun 15, 2023

Currently, functions from dea_tools.classification access spatial information about datacube-loaded data using the .geobox extension, and geometry tools from datacube.utils.geometry.

In ODC version 1.9 and above, these tools will be deprecated and replaced with odc.geo (see opendatacube/datacube-core#1424).

To future proof our classification/ML tools, we should update our functions to use replacement functionality from odc.geo. For example, accessing spatial information like:

ds.odc.geobox

And geometry tools like:

from odc.geo.geom import Geometry
from odc.geo.xr import assign_crs

# or simply
ds.odc.assign_crs()

https://odc-geo.readthedocs.io/en/latest/api.html

Related issue: #1038

@robbibt
Copy link
Member Author

robbibt commented Jun 15, 2023

This is likely a job to do after we have functioning unit tests, e.g. #1075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants