Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide google maps links for embeds to cover for empty/broken panoids #10

Open
ghost opened this issue Jul 14, 2022 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jul 14, 2022

Some panoids may be incorrect or empty for both guesses and the round data.

If everything is sent and works as expected:

  • Link to location on google maps
  • Link to location in streetview

If panoid is empty or unusable:

  • Link to location on google maps
  • Message saying streetview is unavailable at the time
@ghost ghost added the enhancement New feature or request label Jul 14, 2022
@ghost ghost assigned s0er3n Jul 14, 2022
@s0er3n
Copy link
Collaborator

s0er3n commented Aug 1, 2022

i added in #15 a link to google maps in case there is no photosphere but i am not sure if we need an extra link to google maps or the street view if the panoid is provided.
image
you can get both links from the embeded street view

@ghost
Copy link
Author

ghost commented Aug 2, 2022

i added in #15 a link to google maps in case there is no photosphere but i am not sure if we need an extra link to google maps or the street view if the panoid is provided.
image
you can get both links from the embeded street view

You can try using the following link formats:

When streetview is not available, google maps location from coordinates:

https://www.google.com/maps/@?api=1&map_action=pano&viewpoint=${coordinates}

If streetview is available by pano, not entirely sure if we can have the share button in the embed. We can probably figure out from google maps site it links to and add our own direct link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant