-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flatpak package #486
Comments
Bump 🙂 Could you take a look at it, please? |
@12wk34 Sorry for the delay. Thank you for your work. 👍
I am happy if scrcpy is packaged for many systems, but I have no time to work/maintain them. It seems it is not a strong requirement for the author to be involved. If you are interested, you could maintain the flatpack package like @sisco311 does for the snap package. However, you should not include binaries/zip of sources, but reference the links from github (and the matching sha256) from the json, so that everyone can be sure that the "flatpack recipe" builds the expected sources. A minor remark: why do you need x264 (the encoder) and other stuff for ffmpeg? I guess |
@12wk34 ... could you create a new PR on flathub repo ... just quote this thread there to show you have the approval of upstream(@rom1v ) ... i believe they would add it to flathub once they see that upstream is ok with it ... |
Any news here? An flatpack package is strongly appreciated… |
A problem is that I dont know how to use a custom adb build. the binary from google is not free. It is what need be done before add to flathub |
I guess the source code for adb should be in the AOSP project, somewhere... 😄 At least distros build this in their packages, so it has to be FLOSS. (And you may also look there, Debian or Fedora or so, how they build it.) |
Building adb from source is a PITA. But according to the NOTICE.txt file included in the zip from https://dl.google.com/android/repository/platform-tools_r28.0.3-linux.zip the binary is licensed under the Apache License, Version 2.0 |
Any news? Can't you bundle the one from the platform-tools zip file if this is using the APL-2? |
Building the i.e. adb needs to be present on host, and the scrcpy can run it via flatpak-spawn |
Also, confirming on flatpak IRC:
@sisco311 @maggu2810 Looks like it's OK to bundle it. |
Any news? |
Sorry for the postpone.I dont think it is a goold idea to compile library like ffmpeg in each app in flathub. So i was beeing waiting. I just push a request in flathub( flathub/flathub#1551 ). And the build is sucess. By the way, is there a plan to give scrcpy an icon? |
There is currently no plan to do that (no designer). And there is already an awesome icon |
Hi @rom1v , I installed SCRCPY with Flatpak, however an error happens:
|
Something is very wrong. Lines 217 to 219 in e99b896
Does it work with a non-flatpak version? |
I tried on Win 7 with the same phone, same USB cable and it worked, but when I try endless End (which only accepts Flatpak) it doesn't work |
I'd appreciate a Flatpak build, as I don't use Snap. Unfortunately, this issue seems to have been abandoned. |
One alternative/workaround might be the flatpak version my note:
Some other might noteworthy things: |
nearly months, this works okay:
NOTE: a bad thing is, the port may change ... so that need manually re-connect |
Hello, since the last Flatpak packaging attempt stalled, I made another one at Fei1Yang/[email protected] which addressed two problems mentioned by Flathub maintainers in the last attempt using a wrapper script. this method works fairly well during my testing. Regarding the adb issue, there is a more lightweight method to compile it at nmeum/android-tools (and it's being used by Fedora's Anitya project to monitor new releases for adb), but I'm not sure if a switch is necessary since the Google binary is already Apache-2.0 licensed. If the scrcpy developers are satisfied with this manifest, I will try to submit it to flathub. |
Hi,I have packaged scrcpy with flatpak.You can find it in https://github.com/12wk34/scrcpy-flatpak
Could you add it to flathub.org cause they require the developer to do it.
The more information about app submission: https://github.com/flathub/flathub/wiki/App-Submission
The text was updated successfully, but these errors were encountered: