Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyGMT website: Drop-down menu for selection version disappears for selection "dev" #3542

Open
yvonnefroehlich opened this issue Oct 21, 2024 · 5 comments · Fixed by #3597
Open
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@yvonnefroehlich
Copy link
Member

I just found that the drop-down menu for selecting the version on the PyGMT website disappears when having "dev" selected. I think this is somehow new and is still not the case for the GMT website (https://docs.generic-mapping-tools.org/dev/index.html).

<= v0.13.0 latest dev
website_pygmt_select_version_v0130 website_pygmt_select_version_LATEST website_pygmt_select_version_DEV
@yvonnefroehlich yvonnefroehlich added the question Further information is requested label Oct 21, 2024
@seisman
Copy link
Member

seisman commented Oct 21, 2024

It's likely because breaking changes in sphinx_rtd_theme v3.x (https://github.com/readthedocs/sphinx_rtd_theme/tags).

@yvonnefroehlich
Copy link
Member Author

yvonnefroehlich commented Oct 21, 2024

Maybe this iusse is related by the newly introduced version_selector :

At the moment I am trying to understand how this has to be set up, considering these aspects:

@yvonnefroehlich yvonnefroehlich added bug Something isn't working documentation Improvements or additions to documentation and removed question Further information is requested labels Oct 21, 2024
@yvonnefroehlich yvonnefroehlich added the help wanted Helping hands are appreciated label Nov 6, 2024
@seisman
Copy link
Member

seisman commented Nov 7, 2024

We probably should pin sphinx_rtd_theme to 2.x temporarily and wait to see if there are any upstream changes (xref: readthedocs/sphinx_rtd_theme#1624).

@yvonnefroehlich
Copy link
Member Author

We probably should pin sphinx_rtd_theme to 2.x temporarily and wait to see if there are any upstream changes (xref: readthedocs/sphinx_rtd_theme#1624).

I did not see this issue yet. Thanks for pointing it out! This looks like that there are some issues with this newly added version_selector. So trying to pin sphinx_rtd_theme makes sense to me. We can still make changes to the config file.

@seisman
Copy link
Member

seisman commented Nov 8, 2024

reopen so that we can better track possible upstream changes.

@yvonnefroehlich yvonnefroehlich removed the help wanted Helping hands are appreciated label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants