-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CMake package discovery and streamline library setup. #196
Open
Priyanka328
wants to merge
6
commits into
Gecode:release/6.3.0
Choose a base branch
from
Priyanka328:release/6.3.0
base: release/6.3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Priyanka328
commented
Mar 5, 2024
- Resolved CMake package discovery issue for external projects.
- Refactored library setup for improved modularity and organization.
- Enhanced installation process with proper targets.
- Added support for C++17 features in the library.
- Created a CMake export for the library interface to facilitate external use.
- Resolved CMake package discovery issue for external projects. - Refactored library setup for improved modularity and organization. - Enhanced installation process with proper targets. - Added support for C++17 features in the library. - Created a CMake export for the library interface to facilitate external use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been on my list to do so that I could finish up my vcpkg port…
Dekker1
suggested changes
Mar 27, 2024
Thanks for the help in reviewing @waywardmonkeys and @Dekker1. Running the CI and will be testing locally as well. |
Hi everyone, any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.