Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unit tests for attached vs detached set operations #198

Open
johann-petrak opened this issue Apr 26, 2023 · 0 comments
Open

More unit tests for attached vs detached set operations #198

johann-petrak opened this issue Apr 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@johann-petrak
Copy link
Collaborator

Especially also checking the impact of the owning set field!

Especially:

  • remove(annotationinstance):
    • the instance must be directly included in the set, based on the hash function used which is the default (so based on object id)
    • since only directly included annotations can be removed, anything where the owning set does not match is automatically rule out. However checking if owning sets match first may give better hints in the case of an error (better then key error).
    • CHANGE: always try to remove from set first, then remove id from map, that way we cannot be left with an inconsistent state!
@johann-petrak johann-petrak added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant