Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use plugin dependencies to trigger builds #5

Open
greenwoodma opened this issue Jul 3, 2017 · 4 comments
Open

use plugin dependencies to trigger builds #5

greenwoodma opened this issue Jul 3, 2017 · 4 comments

Comments

@greenwoodma
Copy link
Contributor

some of the plugins depend on each other, in these cases a commit should also rebuild the related plugins to check that they not only build but that the gapp loading tests still pass

@ianroberts
Copy link
Member

Note that some of the gapp loading tests introduce dependencies that aren't obvious to Maven, for example the alignment plugin contains a gapp that loads lang-hindi, the twitter plugin contains a gapp that loads stanford-corenlp, etc.

@greenwoodma
Copy link
Contributor Author

not sure the best way of automating this yet, but once you know this is an issue then you can add the info to the Jenkinsfile. i.e the twitter plugin should reference the corenlp plugin so it gets built and tested after any change to corenlp.

@greenwoodma
Copy link
Contributor Author

but we should also see if we can automate the maven dependencies being build triggers as well

@greenwoodma
Copy link
Contributor Author

we now generate the creole-dependencies.txt files which we might be able to use for this. goodness knows how though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants