Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project search is case sensitive #405

Open
freddyheppell opened this issue Mar 13, 2024 · 2 comments · Fixed by #406
Open

Project search is case sensitive #405

freddyheppell opened this issue Mar 13, 2024 · 2 comments · Fixed by #406
Labels
bug Something isn't working

Comments

@freddyheppell
Copy link
Member

Describe the bug

Searching the list of projects is case-sensitive. This makes searching difficult if you're not sure of the exact name of the project, e.g. searching "narrative" will work if the project is called "Tweet narrative" but not "Tweet Narrative" or "Narrative of Politician Tweets" etc...

To Reproduce

Steps to reproduce the behavior:

  1. Create a project called "My Project"
  2. Search "My project"

Expected behavior

Results will be returned regardless of case

Additional context

The RPC backend uses .filter(name__contains=filters.strip()) to handle searching. Per the Django docs this can be changed to .filter(name__icontains=filters.strip()).

@freddyheppell freddyheppell added the bug Something isn't working label Mar 13, 2024
@ianroberts
Copy link
Member

Sounds like a sensible change, feel free to submit a PR.

@ianroberts
Copy link
Member

Thanks for the PR, this issue should close automatically when we merge dev to master to make the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants