Broken when + character is in the description

[yzimet]

If the description contains a + character (maybe others too?), the resulting image is broken:

[trotzig]

Hi @yzimet, and thanks for the report! Judging by the screenshot, it looks like you are running a fairly old version of happo. I tried to reproduce this with the latest version, but it looks like we correctly escape characters at this point.

Can you give a later version a try?

[lencioni]

This is from Happo 4.0.1, which I think is the latest version.

[lencioni]

When I looked at it, it seemed like the URL was correctly encoded on the page, but the asset didn't exist. I wonder if there is something weird with the uploader.

[trotzig]

Ah, I rushed to conclusions. I looked at the screenshot and didn't see the tabs above the image, thinking it was an old version. But I now realize that screenshot is probably for a new image, correct?

We're not doing much on our end to escape things. We basically pass in a Key and then use the Location that's sent back in the response from aws. Relevant code:

happo/packages/happo-uploader-s3/src/S3Uploader.js

Line 102 in c291f5f

this.s3.upload(uploadParams, (err, { Location }) => {