Skip to content

Commit 3bc4be2

Browse files
committed
Fixed broken tests
1 parent d5b552c commit 3bc4be2

File tree

6 files changed

+15
-42
lines changed

6 files changed

+15
-42
lines changed

.travis.yml

Lines changed: 0 additions & 30 deletions
This file was deleted.

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99
Go library for handling Source Engine .bsp map files.
1010

1111
### Features:
12-
* Read support for (most) non-xbox360 bsps (v20,21). v19 support limited, may work
12+
* Read support for (most) non-xbox360 BSPs (v20,21). v19 support limited, may work
1313
* Freely modify and resize any Lump data
1414
* Limited write support, mostly untested
1515

16-
##### Not all lumps are current supported, but can be freely read and modified, as they are treated as `[]byte`
16+
##### Not all lumps are currently supported, but can be freely read and modified, as they are treated as `[]byte`
1717

18-
The following lumps currently have a full implementation for v20 & v21 bsp's (tested against CS:S & CS:GO):
18+
The following lumps currently have a full implementation for v20 & v21 BSPs (tested against CS:S & CS:GO):
1919

2020
```
2121
0: Entdata
@@ -63,6 +63,7 @@ The following lumps currently have a full implementation for v20 & v21 bsp's (te
6363
48: DispTris
6464
51: LeafAmbientIndexHDR
6565
52: LeafAmbientIndex
66+
53: WorldLightHDR
6667
54: WorldLightHDR
6768
55: LeafAmbientLightingHDR
6869
56: LeafAmbientLighting

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ go 1.12
44

55
require (
66
github.com/go-gl/mathgl v1.0.0
7-
golang.org/x/image v0.0.0-20210220032944-ac19c3e999fb // indirect
7+
golang.org/x/image v0.0.0-20210504121937-7319ad40d33e // indirect
88
)

go.sum

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
1-
github.com/go-gl/mathgl v0.0.0-20190713194549-592312d8590a h1:yoAEv7yeWqfL/l9A/J5QOndXIJCldv+uuQB1DSNQbS0=
2-
github.com/go-gl/mathgl v0.0.0-20190713194549-592312d8590a/go.mod h1:yhpkQzEiH9yPyxDUGzkmgScbaBVlhC06qodikEM0ZwQ=
31
github.com/go-gl/mathgl v1.0.0 h1:t9DznWJlXxxjeeKLIdovCOVJQk/GzDEL7h/h+Ro2B68=
42
github.com/go-gl/mathgl v1.0.0/go.mod h1:yhpkQzEiH9yPyxDUGzkmgScbaBVlhC06qodikEM0ZwQ=
5-
golang.org/x/image v0.0.0-20190321063152-3fc05d484e9f h1:FO4MZ3N56GnxbqxGKqh+YTzUWQ2sDwtFQEZgLOxh9Jc=
63
golang.org/x/image v0.0.0-20190321063152-3fc05d484e9f/go.mod h1:kZ7UVZpmo3dzQBMxlp+ypCbDeSB+sBbTgSJuh5dn5js=
7-
golang.org/x/image v0.0.0-20190910094157-69e4b8554b2a h1:gHevYm0pO4QUbwy8Dmdr01R5r1BuKtfYqRqF0h/Cbh0=
8-
golang.org/x/image v0.0.0-20190910094157-69e4b8554b2a/go.mod h1:FeLwcggjj3mMvU+oOTbSwawSJRM1uh48EjtB4UJZlP0=
94
golang.org/x/image v0.0.0-20210220032944-ac19c3e999fb h1:fqpd0EBDzlHRCjiphRR5Zo/RSWWQlWv34418dnEixWk=
105
golang.org/x/image v0.0.0-20210220032944-ac19c3e999fb/go.mod h1:FeLwcggjj3mMvU+oOTbSwawSJRM1uh48EjtB4UJZlP0=
6+
golang.org/x/image v0.0.0-20210504121937-7319ad40d33e h1:PzJMNfFQx+QO9hrC1GwZ4BoPGeNGhfeQEgcQFArEjPk=
7+
golang.org/x/image v0.0.0-20210504121937-7319ad40d33e/go.mod h1:FeLwcggjj3mMvU+oOTbSwawSJRM1uh48EjtB4UJZlP0=
118
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=

lump_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ func getExpectedLump(index int) lumps.ILump {
132132
&lumps.Unimplemented{},
133133
&lumps.LeafAmbientIndexHDR{},
134134
&lumps.LeafAmbientIndex{},
135-
&lumps.Unimplemented{},
135+
&lumps.Lighting{},
136136
&lumps.WorldLightHDR{},
137137
&lumps.LeafAmbientLightingHDR{},
138138
&lumps.LeafAmbientLighting{},

primitives/game/staticpropv10_test.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func TestStaticPropV10_GetDiffuseModulation(t *testing.T) {
2424

2525
func TestStaticPropV10_GetDisableXBox360(t *testing.T) {
2626
sut := getStaticPropV10()
27-
if sut.GetDisableXBox360() != true {
27+
if sut.GetDisableXBox360() != false {
2828
t.Error("unexpected value for unknown property")
2929
}
3030

@@ -174,15 +174,20 @@ func TestStaticPropV10_GetUniformScale(t *testing.T) {
174174
if sut.GetUniformScale() != 1 {
175175
t.Error("unexpected value for uniformScale property")
176176
}
177+
}
177178

179+
func TestStaticPropV10_GetExtraFlags(t *testing.T) {
180+
sut := getStaticPropV10()
181+
if sut.GetExtraFlags() != 0 {
182+
t.Error("unexpected value for extra flags property")
183+
}
178184
}
179185

180186
func TestStaticPropV10_GetUnknown(t *testing.T) {
181187
sut := getStaticPropV10()
182188
if sut.GetUnknown() != 0 {
183189
t.Error("unexpected value for unknown property")
184190
}
185-
186191
}
187192

188193
func getStaticPropV10() *StaticPropV10 {

0 commit comments

Comments
 (0)