Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID type reconcillation #283

Open
TheMrMilchmann opened this issue Feb 2, 2024 · 0 comments
Open

ID type reconcillation #283

TheMrMilchmann opened this issue Feb 2, 2024 · 0 comments
Labels
a:feature New feature or request good first issue Good for newcomers in:api-v1 in:api-v2
Milestone

Comments

@TheMrMilchmann
Copy link
Member

In #199, support for type aliases was introduced. Aliases are important for declaring type-safe ID types and are used in the spec in several places for exactly this purpose. However, not all ID types have been extracted into aliases yet and there are still a couple of places, where the old "plain" types are used for IDs for which an alias exists.

To clean this up ahead of a stable release, it is necessary to go through the entire specification once again. For all ID types under com/gw2tb/apigen/internal/spec, an alias should be created in common. Further, those aliases should replace the previous primitive types in places, where the ID type should be referenced.

@TheMrMilchmann TheMrMilchmann added good first issue Good for newcomers a:feature New feature or request in:api-v2 in:api-v1 labels Feb 2, 2024
@TheMrMilchmann TheMrMilchmann added this to the 0.8.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request good first issue Good for newcomers in:api-v1 in:api-v2
Projects
None yet
Development

No branches or pull requests

1 participant