Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility request]: Heart Crystal #3

Open
Omgise opened this issue Feb 3, 2025 · 5 comments
Open

[Compatibility request]: Heart Crystal #3

Omgise opened this issue Feb 3, 2025 · 5 comments
Labels
compat request Mod compatibility request

Comments

@Omgise
Copy link

Omgise commented Feb 3, 2025

Image

@Omgise
Copy link
Author

Omgise commented Feb 3, 2025

@FalsePattern
Copy link
Contributor

FalsePattern commented Feb 3, 2025

Not a rendering bug, heart crystals can't be waterlogged yet. The current version of FluidLogged only has support for a set number of built-in block types, I'll add better extensibility in the future.

@FalsePattern FalsePattern changed the title Strange rendering of the Heart Crystal in water [Compat request] Heart Crystal Feb 3, 2025
@FalsePattern FalsePattern added the compat request Mod compatibility request label Feb 3, 2025
@FalsePattern FalsePattern changed the title [Compat request] Heart Crystal [Compatibility request]: Heart Crystal Feb 3, 2025
@FalsePattern
Copy link
Contributor

This is where the current list of supported blocks is stored at the moment:

{
waterLoggableClasses.add(BlockChest.class);
waterLoggableClasses.add(BlockEnderChest.class);
waterLoggableClasses.add(BlockFence.class);
waterLoggableClasses.add(BlockPane.class);
waterLoggableClasses.add(BlockLadder.class);
waterLoggableClasses.add(BlockRailBase.class);
waterLoggableClasses.add(BlockSign.class);
waterLoggableClasses.add(BlockSlab.class);
waterLoggableClasses.add(BlockStairs.class);
waterLoggableClasses.add(BlockTrapDoor.class);
lavaLoggable.add(Blocks.nether_brick_fence);
lavaLoggable.add(Blocks.iron_bars);
lavaLoggable.add(Blocks.stone_slab);
lavaLoggable.add(Blocks.stone_stairs);
lavaLoggable.add(Blocks.brick_stairs);
lavaLoggable.add(Blocks.stone_brick_stairs);
lavaLoggable.add(Blocks.nether_brick_stairs);
lavaLoggable.add(Blocks.sandstone_stairs);
lavaLoggable.add(Blocks.quartz_stairs);
}

@Roadhog360
Copy link

Roadhog360 commented Feb 4, 2025

Could make it CraftTweakable where users can add stuff to the list through CraftTweaker?

@FalsePattern
Copy link
Contributor

Could make it CraftTweakable where users can add stuff to the list through CraftTweaker?

Yep, that's my current plan, a crafttweaker api, i just need to figure out how to make one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat request Mod compatibility request
Projects
None yet
Development

No branches or pull requests

3 participants