Task: Adjust and improve the API and Admin code to merge the latest version of flake8-bugbear in each repo #2054
Description
The flake8-bugbear dependency, which performs additional Python linting and style checks for us that catch likely causes for bugs, was recently updated with some newly added checks that are now triggering for us. We need to go through and either make the suggested updates/improvements, or explicitly ignore the warnings if they do not make sense and do not apply to us (though I find that unlikely!).
If you pull the Dependabot PRs down locally and run make bootstrap to install the dependency update, you can easily check and make the changes locally directly in the PR and push the updates back into the PR to get things working again and in a better state. 🙂
Implementation Sketch and Acceptance Criteria
- Review the
flake8-bugbearwarnings and failures in the automated tests for the Dependabot PRs opened in the API and Admin repos to determine what needs to change - Make the necessary changes (or add explicit ignore markers) in the API repo Dependabot PR
- Make the necessary changes (or add explicit ignore markers) in the Admin repo Dependabot PR
Security Considerations
- Style and linting checks help reduce our chances of introducing or carrying bugs and tech debt in our code while also improving our ability to maintain things.