Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fGammaCorrection = 0 for CMP_CFilterParams #326

Open
FilippoLeon opened this issue Nov 28, 2024 · 0 comments · May be fixed by #327
Open

fGammaCorrection = 0 for CMP_CFilterParams #326

FilippoLeon opened this issue Nov 28, 2024 · 0 comments · May be fixed by #327

Comments

@FilippoLeon
Copy link

A value of 0 for fGammaCorrection in CMP_CFilterParams when used in CMP_GenerateMIPLevelsEx would use a gamma of 0, but the documentation says a value of zero would result in no correction

// Apply Gamma correction to RGB channels, using this value as a power exponent,value of 0 or 1 = no correction

The documentation seems more correct, as usually a "zeroed" out struct should result in a sensible default.
@FilippoLeon FilippoLeon changed the title CMP_CFilterParams fGammaCorrection = 0 for CMP_CFilterParams fGammaCorrection = 0 for CMP_CFilterParams Nov 28, 2024
@FilippoLeon FilippoLeon linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix https://github.com/GPUOpen-Tools/compressonator/issues/326 FilippoLeon/compressonator
1 participant
@FilippoLeon