Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if attributes make sense #878

Open
Gigaszi opened this issue Feb 6, 2025 · 2 comments
Open

check if attributes make sense #878

Gigaszi opened this issue Feb 6, 2025 · 2 comments
Assignees

Comments

@Gigaszi
Copy link
Collaborator

Gigaszi commented Feb 6, 2025

The attribute residential for roads doesnt make sense for a quality indicator. We should probably delete it and check the other attributes

@JanReifenrath JanReifenrath self-assigned this Feb 7, 2025
@JanReifenrath
Copy link
Collaborator

i added that attribute partly because it is the most common tag for highway but i'll admit it doesn't really make sense for attribute completeness - will remove it and check if there are others that do not make much sense.

@JanReifenrath
Copy link
Collaborator

JanReifenrath commented Feb 10, 2025

Many atrributes for the topic clinics are not very suitable for the attribute completeness indicator (healthcare=rehabilitation etc.) because not all clinics should have this. The same goes for the attribute winery (craft=winery) from the marketplace topic. I have not removed these yet because they were added by request of the BKG. Should they be removed anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants