feat!: various improvements 2024-06 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- plugin.xml id & version should match with package.json as it will be added to cordova object in app's package.json
plugin should already install production npm packages in added.
NiklasMerz
reviewed
Jun 9, 2024
Collaborator
NiklasMerz
left a comment
NiklasMerz
left a comment
There was a problem hiding this comment.
Codewise it looks good but it needs to be tested with a production setup.
|
I've tested this PR with our application and the changes look good for production |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignoreto not commitnode_modulescordova-commonas a dependency to not rely on the package in lib/cliconfigXmlHelper.jsplugin.xmlto matchpackage.json. Mismatch causes incorrect plugin install when usingcordova prepareconfigXmlHelper&configXmlParserforExtendedConfigParsernode-version-comparedependencyRemoved dependencies
mkpathforfs.mkdirSyncrimrafforfs.rmSync[email protected][email protected]ExtendedConfigParseriosBeforePrepareHookbeforePluginInstallHook- Plugin should already install production npm packages in added