리소스 room 추가 #4
#5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
gusrb3164
reviewed
Feb 7, 2021
|
LGTM! 👍 |
|
형진님 코드 pull 받아서 합쳐야할까요? |
제 코드랑 겹치는 부분이 없어서 그럴 필요는 없을 것 같아요! |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request from #4
작업 내용
modelRoom을room.model.js에 정의했어요.pin,gameId,gamers로 구성되어 있습니다.POST /room을 구현했어요.gameId를 받습니다.DELETE /room/:roomId를 구현했어요.roomId를 가진room을 찾고 지웁니다./api/room으로 접속할 수 있도록routes/api/index.js에 추가했습니다.리뷰 노트
game이 없기 때문에,gameId유효 확인 로직은 나중에 따로 Issue 생성하겠습니다.