Skip to content

Lesson 25, inconsistency between add_unit example call arguments and practice exercise place_unit function #981

Open
@jman904

Description

@jman904

Near the bottom of lesson 25 there is the following code snippet:

1 func run():
2   for cell in unit_cells:
3     var unit = unit_cels[cell]
4     add_unit(unit, cell)

I thought the arg ordering of add_unit was a little strange at first as add_unit(coordinate, unit_name) just feels more intuitive. Sure enough, in the 2nd practice example the order of the args for place_unit is in this order (i.e., place_unit(cell:Vector2, unit_type: String) ). It would probably add clarity to use the same function name, with the same argument ordering, in lesson module associated with the practice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    contentIssues with the lessons, practices, including their code examples

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions