Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Arabic Translation #86

Open
kalmufti opened this issue Oct 15, 2018 · 11 comments
Open

Arabic Translation #86

kalmufti opened this issue Oct 15, 2018 · 11 comments
Labels
translation Translating the presentation to a new language or fixing an existing one

Comments

@kalmufti
Copy link

I will work on the Arabic translation. Great project thanks @NathanLovato!

@kalmufti
Copy link
Author

I'm having an issue, Arabic is not being displayed on the slides, think maybe I need to add Arabic font? I've noticed the fonts directory but I'm not sure if I just need to add a font there or do I also need to update settings/scripts?

@NathanLovato
Copy link
Contributor

You need some code for that too. Give me a moment, I'll add that. Which locales should use this font?

@kalmufti
Copy link
Author

Cool thanks! Locales = ar.

@NathanLovato
Copy link
Contributor

Just added an arabic font as a fallback. Please check and tell me if it's working. If not, could you translate a slide or two and just send me the csv file? so I can test this and fix the display directly

@NathanLovato
Copy link
Contributor

See 5e6e504

@NathanLovato NathanLovato added the translation Translating the presentation to a new language or fixing an existing one label Oct 16, 2018
@kalmufti
Copy link
Author

Check the second slide, the title still not showing though the text on the left is working but disjointed, in Arabic the words are joined just like writing cursive in English.

PowerPitch.csv.zip

@NathanLovato
Copy link
Contributor

As far as I know Godot doesn't support ligatures and complex font rendering as of yet: godotengine/godot#9961
So it can display various languages but the characters may be disjointed at times.

@NathanLovato
Copy link
Contributor

Pushing a fix now, that's the best we'll get for the moment

image

@NathanLovato
Copy link
Contributor

There you go, please update the project to the latest master ( 6cb67aa )

@NathanLovato
Copy link
Contributor

Hi, any update on this issue or should I close it?

@kalmufti
Copy link
Author

Hi Nathan, I've already done most of the translations, was waiting for this work godotengine/godot#21791 to be merged to 3.1 but it seems they pushed it to 3.2. I guess I can finish the translation, push the change to you and have there until we can test on 3.2, because as of the current state it's unreadable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
translation Translating the presentation to a new language or fixing an existing one
Projects
None yet
Development

No branches or pull requests

2 participants