Skip to content

Commit f3bc13b

Browse files
authored
Merge pull request #819 from jgrewe/index_of
Adaptations for RangeDimension indexOf methods LGTM
2 parents 3161216 + ec46176 commit f3bc13b

File tree

10 files changed

+1561
-276
lines changed

10 files changed

+1561
-276
lines changed

include/nix/Dimensions.hpp

Lines changed: 259 additions & 22 deletions
Large diffs are not rendered by default.

include/nix/util/dataAccess.hpp

Lines changed: 96 additions & 46 deletions
Large diffs are not rendered by default.

src/Dimensions.cpp

Lines changed: 301 additions & 31 deletions
Large diffs are not rendered by default.

src/util/dataAccess.cpp

Lines changed: 253 additions & 119 deletions
Large diffs are not rendered by default.

test/BaseTestDataAccess.cpp

Lines changed: 196 additions & 33 deletions
Large diffs are not rendered by default.

test/BaseTestDataAccess.hpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@ class BaseTestDataAccess : public CPPUNIT_NS::TestFixture {
2626

2727
public:
2828
void testPositionToIndexSetDimension();
29+
void testPositionToIndexSetDimensionOld();
2930
void testPositionToIndexSampledDimension();
31+
void testPositionToIndexSampledDimensionOld();
3032
void testPositionToIndexRangeDimension();
33+
void testPositionToIndexRangeDimensionOld();
3134
void testOffsetAndCount();
3235
void testPositionInData();
3336
void testRetrieveData();

test/BaseTestDimension.cpp

Lines changed: 441 additions & 24 deletions
Large diffs are not rendered by default.

test/BaseTestDimension.hpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,23 @@ class BaseTestDimension : public CPPUNIT_NS::TestFixture {
3333
void testSampledDimUnit();
3434
void testSampledDimSamplingInterval();
3535
void testSampledDimOperators();
36+
void testSampledDimIndexOfOld();
3637
void testSampledDimIndexOf();
3738
void testSampledDimPositionAt();
3839
void testSampledDimAxis();
3940

4041
void testSetDimLabels();
42+
void testSetDimIndexOf();
4143

4244
void testRangeDimLabel();
4345
void testRangeTicks();
4446
void testRangeDimUnit();
47+
void testRangeDimIndexOfOld();
4548
void testRangeDimIndexOf();
4649
void testRangeDimTickAt();
4750
void testRangeDimAxis();
48-
51+
void testRangeDimPositionInRange();
52+
4953
void testAsDimensionMethods();
5054
};
5155

test/hdf5/TestDataAccessHDF5.hpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@ class TestDataAccessHDF5 : public BaseTestDataAccess {
1717

1818
CPPUNIT_TEST_SUITE(TestDataAccessHDF5);
1919
CPPUNIT_TEST(testPositionToIndexSampledDimension);
20+
CPPUNIT_TEST(testPositionToIndexSampledDimensionOld);
2021
CPPUNIT_TEST(testPositionToIndexSetDimension);
22+
CPPUNIT_TEST(testPositionToIndexSetDimensionOld);
2123
CPPUNIT_TEST(testPositionToIndexRangeDimension);
24+
CPPUNIT_TEST(testPositionToIndexRangeDimensionOld);
2225
CPPUNIT_TEST(testOffsetAndCount);
2326
CPPUNIT_TEST(testPositionInData);
2427
CPPUNIT_TEST(testRetrieveData);

test/hdf5/TestDimensionHDF5.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,17 @@ class TestDimensionHDF5 : public BaseTestDimension {
2626
CPPUNIT_TEST(testSampledDimSamplingInterval);
2727
CPPUNIT_TEST(testSampledDimOperators);
2828
CPPUNIT_TEST(testSampledDimIndexOf);
29+
CPPUNIT_TEST(testSampledDimIndexOfOld);
2930
CPPUNIT_TEST(testSampledDimPositionAt);
3031
CPPUNIT_TEST(testSampledDimAxis);
3132
CPPUNIT_TEST(testSetDimLabels);
33+
CPPUNIT_TEST(testSetDimIndexOf);
3234
CPPUNIT_TEST(testRangeDimLabel);
3335
CPPUNIT_TEST(testRangeDimUnit);
3436
CPPUNIT_TEST(testRangeTicks);
37+
CPPUNIT_TEST(testRangeDimIndexOfOld);
3538
CPPUNIT_TEST(testRangeDimIndexOf);
39+
CPPUNIT_TEST(testRangeDimPositionInRange);
3640
CPPUNIT_TEST(testRangeDimTickAt);
3741
CPPUNIT_TEST(testRangeDimAxis);
3842
CPPUNIT_TEST(testAsDimensionMethods);

0 commit comments

Comments
 (0)