Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetIconAttribute on method not working because of a validation bug (fix included) #41

Open
zacx-z opened this issue Feb 18, 2021 · 1 comment
Assignees
Labels
🐛 bug Something isn't working

Comments

@zacx-z
Copy link

zacx-z commented Feb 18, 2021

When applied to a parameterless method, logging "method should have no parameters" error. Figured it's the bug in the condition of validation. In GraphicSourceSelector.cs, line 108:

		private static bool IsSupportedParameters(Type[] parameterTypes)
		{
			return parameterTypes.Length != 0;
		}

should be

			return parameterTypes.Length == 0;
@zacx-z zacx-z added the 🐛 bug Something isn't working label Feb 18, 2021
@gjroelofs
Copy link

Ran into this as well at a gamejam, cheers for the attached fix @zacx-z.

@Fydar Fydar self-assigned this Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants