Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Changes To Vocal Track Muting On Miss #3950

Open
2 tasks done
Average-FNF-Modder opened this issue Dec 24, 2024 · 1 comment
Open
2 tasks done

Enhancement: Changes To Vocal Track Muting On Miss #3950

Average-FNF-Modder opened this issue Dec 24, 2024 · 1 comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature.

Comments

@Average-FNF-Modder
Copy link

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

I'm here to suggest 2 modifications to the way the muting of the vocal track when the player is missing is handled.
First, I would suggest having ghost misses no longer mute the track. There's no reason pressing an extra note should mute the track when you still hit all the singing notes in my eyes. The second change I would make is to have regular note miss mutes go away after sometime, in my opinion like 1 single beat, of course with that timer getting reset every time you miss again. These changes make a couple things nicer. For one thing, if the player only has one vocal track instead of separated vocals, it'll stop ghost misses or a miss on the final note of a set from completely muting the opponent's side till the player gets to hit a note again. Even with separated vocals, there may be flairs like Pico's burping that get played without a note, that ghost misses and misses of the previous note could fuck up for no reason.

@Average-FNF-Modder Average-FNF-Modder added status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature. labels Dec 24, 2024
@Hundrec
Copy link
Contributor

Hundrec commented Dec 24, 2024

#3012 removes ghost muting.

For your second suggestion, I'm concerned that could cause a side effect where Boyfriend beeps a tiny bit before missing again, negating the muting of his vocals. Perhaps this could be done if the game detects only a single vocal track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

2 participants