Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Remove (or at least improve) the potential duplicate workflow/job #3943

Closed
2 tasks done
AbnormalPoof opened this issue Dec 18, 2024 · 2 comments
Closed
2 tasks done
Labels
status: resolved The issue has been clarified or fixed. type: documentation Is related to improvements or additions to documentation.

Comments

@AbnormalPoof
Copy link
Contributor

AbnormalPoof commented Dec 18, 2024

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

The potential duplicate workflow, on paper, is a great way to check if any issues are potentially... well... duplicates.
In reality, this kinda sucks.

9 times out of 10, the bot is just blatantly incorrect:
Screenshot 2024-12-17 at 5 59 11 PM
Screenshot 2024-12-17 at 5 58 51 PM
Even at high confidence (the % next to each issue), the bot is still wrong.
It doesn't help that this runs every time an issue is edited, which can lead to it commenting on 'potential duplicate' issues multiple times if one were to edit it a lot.

Basically it's not really doing much for the Issues tab right now. My suggestion is to either remove it entirely, or find some way to improve it's accuracy since it could have some potential if improved upon.

@AbnormalPoof AbnormalPoof added status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature. labels Dec 18, 2024
@EliteMasterEric
Copy link
Member

Here's the action being used: https://github.com/wow-actions/potential-duplicates

I picked it up since it seemed like it would be useful but it appears it hasn't played out well in practice. Re-running on edit is definitely a configuration issue.

Since it doesn't seem like it has been helpful, I'm going to remove it in a minute. Was a good experiment at least.

@EliteMasterEric
Copy link
Member

Done.

@EliteMasterEric EliteMasterEric added type: documentation Is related to improvements or additions to documentation. status: resolved The issue has been clarified or fixed. and removed type: enhancement Provides an enhancement or new feature. status: pending triage The bug or PR has not been reviewed yet. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved The issue has been clarified or fixed. type: documentation Is related to improvements or additions to documentation.
Projects
None yet
Development

No branches or pull requests

2 participants