Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are not transpiled #86

Open
glebec opened this issue Sep 30, 2016 · 0 comments
Open

Tests are not transpiled #86

glebec opened this issue Sep 30, 2016 · 0 comments

Comments

@glebec
Copy link
Member

glebec commented Sep 30, 2016

Eventually the standard Node version will contain enough ES6 so that this becomes moot, but at least for now, FSG transpiles server & browser code but not test code. This can cause problems e.g. on Codeship if people are using the (current) default Node env of v5. A few possible solutions, one of which is already in place:

  • Make sure the Codeship testing wiki instructions include nvm use v6 or similar. This is currently in effect, but is annoying to hard-code into the wiki — by rights this line probably shouldn't exist.
  • Make sure the generated package.json lists a node version in engines that is ES6 compatible, as Codeship reads that file when starting a build. If we transpile tests, this isn't necessary.
  • Transpile tests. This maintains parity with server & browser code and lets us easily update the transpiler for the entire project in the future, e.g. ES7 -> ES6 or similar. This is probably the best route though it is not mutually exclusive with the other options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant