Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest eslint breaks this plugin #74

Open
ghost opened this issue Jun 25, 2019 · 2 comments
Open

Newest eslint breaks this plugin #74

ghost opened this issue Jun 25, 2019 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Jun 25, 2019

Expected Behavior

Running npm install -g eslint eslint-config-fullstack eslint-plugin-react babel-eslint and creating the file ~/.eslintrc.json with the following contents:

{
  "extends": "fullstack",
  "parser": "babel-eslint",
  "rules": {
    "semi": [1, "always"]
  }
}

Will make eslint work, as per the instructions in the workshop.

Actual Behavior

Running eslint generates the following error message:

Oops! Something went wrong! :(

ESLint: 6.0.1.

ESLint couldn't find the config "fullstack" to extend from. Please check that the name of the config is correct.

The config "fullstack" was referenced from the config file in "/Users/joshua/.eslintrc.json".

If you still have problems, please stop by https://gitter.im/eslint/eslint to chat with the team.

Temporary Workaround

Downgrading eslint to version 5.0.1 works. I modified the instructions to:

npm install -g [email protected] eslint-config-fullstack eslint-plugin-react babel-eslint

And everything worked perfectly.

@glebec
Copy link
Member

glebec commented Jun 25, 2019

Thanks for the note, I need to do a lot of housekeeping on the versions here. I should also amend the installation instructions to be pinned to compatible versions so that this doesn't happen every time the peer deps fall out of sync. Will get on this soon, maybe later this week.

@glebec glebec self-assigned this Jun 25, 2019
@glebec glebec added the bug label Jun 25, 2019
@glebec glebec removed their assignment Nov 12, 2021
@glebec
Copy link
Member

glebec commented Nov 12, 2021

I don't have write access to this anymore, so someone at Fullstack will have to attend to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant