-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add RVRT to unallowed opcodes for predicates #6290
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a test.
Thank you for reviewing my draft! I am working on adding the tests. Could you point me to where the existing tests are, or we need to create new one? |
|
It's straightforward to update the I also cannot find a clear description of how to run the tests and ensure they pass. |
The changes are not big and I believe they pass, but need this to be reviewed and also further docs on how to run the tests. Instructions on how the tests work will be appreciated too |
The provided test should be enough. Check the CI execution to see what commands to run specific tests locally |
Statically prevent RVRT in predicates opcodes
Closes #5986
Checklist
Breaking*
orNew Feature
labels where relevant.