Sway hex literals have their suffix counted as digits

[camden-smallwood]

Related Component

compiler

Problem

As the title states, hex literals have their optional suffix counted as part of their digits. This causes the following error, and related errors for types aside from b256:

  --> /Users/camden/Source/charcoal/out/ds_auth/src/main.sw:69:75
   |
67 |     } else if src == storage.owner.read() {
68 |         return true;
69 |     } else if storage.authority.read() == Identity::Address(Address::from(0x0000000000000000000000000000000000000000000000000000000000000000b256)) {
   |                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ hex literals must have 1..16 or 64 digits
70 |         return false;
71 |     } else {

If we count the zeroes, logically we can deduce that there is in fact exactly 64 digits in the following:

0x0000000000000000000000000000000000000000000000000000000000000000b256

But there is no attempt made to strip the b256 before counting.

Steps

1. Create a sway project.
2. Create a b256 variable using the 0x0000000000000000000000000000000000000000000000000000000000000000b256 constant.
3. Run forc build

Possible Solution(s)

Maybe strip the suffix before this point:

sway/sway-core/src/transform/to_parsed_lang/convert_parse_tree.rs

Lines 3388 to 3402 in 73e1a7a

	if let Some(hex_digits) = orig_str.strip_prefix("0x") {
	let num_digits = hex_digits.chars().filter(|c| *c != '_').count();
	match num_digits {
	1..=16 => Literal::Numeric(u64::try_from(parsed).unwrap()),
	64 => {
	let bytes = parsed.to_bytes_be();
	let mut full_bytes = [0u8; 32];
	full_bytes[(32 - bytes.len())..].copy_from_slice(&bytes);
	Literal::B256(full_bytes)
	}
	_ => {
	let error = ConvertParseTreeError::HexLiteralLength { span };
	return Err(handler.emit_err(error.into()));
	}
	}

Notes

Should be an easy fix, but it should be done ASAP.

Installed components

camden@Camdens-MacBook-Air sway % fuelup check
latest - Up to date
fuelup - Up to date
camden@Camdens-MacBook-Air sway % fuelup show
Default host: aarch64-apple-darwin
fuelup home: /Users/camden/.fuelup

Installed toolchains
--------------------
latest-aarch64-apple-darwin (default)

active toolchain
----------------
latest-aarch64-apple-darwin (default)
  forc : 0.66.4
    - forc-client
      - forc-deploy : 0.66.4
      - forc-run : 0.66.4
    - forc-crypto : 0.66.4
    - forc-debug : 0.66.4
    - forc-doc : 0.66.4
    - forc-fmt : 0.66.4
    - forc-lsp : 0.66.4
    - forc-tx : 0.66.4
    - forc-wallet : 0.11.1
  fuel-core : 0.40.0
  fuel-core-keygen : 0.40.0

fuels versions
--------------
forc : 0.66.9
forc-wallet : 0.66.9