Implement DelineatedPathExpression AST resolve handling.

Author: tritao

sway-core/src/language/parsed/declaration.rs

@@ -122,7 +122,7 @@ impl Declaration {
         }
     }
 
-    pub(crate) fn to_fn_ref(
+    pub(crate) fn to_fn_decl(
         &self,
         handler: &Handler,
         engines: &Engines,
@@ -166,6 +166,34 @@ impl Declaration {
         }
     }
 
+    pub(crate) fn to_enum_decl(
+        &self,
+        handler: &Handler,
+        engines: &Engines,
+    ) -> Result<ParsedDeclId<EnumDeclaration>, ErrorEmitted> {
+        match self {
+            Declaration::EnumDeclaration(decl_id) => Ok(*decl_id),
+            decl => Err(handler.emit_err(CompileError::DeclIsNotAnEnum {
+                actually: decl.friendly_type_name().to_string(),
+                span: decl.span(engines),
+            })),
+        }
+    }
+
+    pub(crate) fn to_const_decl(
+        &self,
+        handler: &Handler,
+        engines: &Engines,
+    ) -> Result<ParsedDeclId<ConstantDeclaration>, ErrorEmitted> {
+        match self {
+            Declaration::ConstantDeclaration(decl_id) => Ok(*decl_id),
+            decl => Err(handler.emit_err(CompileError::DeclIsNotAConstant {
+                actually: decl.friendly_type_name().to_string(),
+                span: decl.span(engines),
+            })),
+        }
+    }
+
     #[allow(unused)]
     pub(crate) fn visibility(&self, decl_engine: &ParsedDeclEngine) -> Visibility {
         match self {

sway-core/src/language/parsed/expression/mod.rs

@@ -23,7 +23,7 @@ pub use method_name::MethodName;
 pub use scrutinee::*;
 use sway_ast::intrinsics::Intrinsic;
 
-use super::{FunctionDeclaration, StructDeclaration};
+use super::{Declaration, FunctionDeclaration, StructDeclaration};
 
 /// Represents a parsed, but not yet type checked, [Expression](https://en.wikipedia.org/wiki/Expression_(computer_science)).
 #[derive(Debug, Clone)]
@@ -295,6 +295,8 @@ impl PartialEqWithEngines for AmbiguousPathExpression {
 #[derive(Debug, Clone)]
 pub struct DelineatedPathExpression {
     pub call_path_binding: TypeBinding<QualifiedCallPath>,
+    pub resolved_call_path_binding: Option<TypeBinding<ResolvedCallPath<Declaration>>>,
+
     /// When args is equal to Option::None then it means that the
     /// [DelineatedPathExpression] was initialized from an expression
     /// that does not end with parenthesis.

sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs

@@ -445,6 +445,7 @@ impl ty::TyExpression {
             ExpressionKind::DelineatedPath(delineated_path_expression) => {
                 let DelineatedPathExpression {
                     call_path_binding,
+                    resolved_call_path_binding: _,
                     args,
                 } = *delineated_path_expression.clone();
                 Self::type_check_delineated_path(

sway-core/src/semantic_analysis/node_dependencies.rs

@@ -634,6 +634,7 @@ impl Dependencies {
             ExpressionKind::DelineatedPath(delineated_path_expression) => {
                 let DelineatedPathExpression {
                     call_path_binding,
+                    resolved_call_path_binding: _,
                     args,
                 } = &**delineated_path_expression;
                 // It's either a module path which we can ignore, or an enum variant path, in which

sway-core/src/semantic_analysis/symbol_resolve.rs

@@ -15,7 +15,7 @@ use crate::{
         },
         CallPath, CallPathTree, ResolvedCallPath,
     },
-    TraitConstraint, TypeArgument, TypeBinding, TypeParameter,
+    TraitConstraint, TypeArgs, TypeArgument, TypeBinding, TypeParameter,
 };
 
 use super::symbol_resolve_context::SymbolResolveContext;
@@ -495,23 +495,14 @@ impl ResolveSymbols for StructScrutineeField {
 }
 
 impl ResolveSymbols for Expression {
-    fn resolve_symbols(&mut self, handler: &Handler, ctx: SymbolResolveContext) {
-        self.kind.resolve_symbols(handler, ctx);
-    }
-}
-
-impl ResolveSymbols for ExpressionKind {
     fn resolve_symbols(&mut self, handler: &Handler, mut ctx: SymbolResolveContext) {
-        match self {
+        match &mut self.kind {
             ExpressionKind::Error(_, _) => {}
             ExpressionKind::Literal(_) => {}
             ExpressionKind::AmbiguousPathExpression(_) => {}
             ExpressionKind::FunctionApplication(expr) => {
-                let result = SymbolResolveTypeBinding::resolve_symbol(
-                    &mut expr.call_path_binding,
-                    &Handler::default(),
-                    ctx.by_ref(),
-                );
+                let result = expr.call_path_binding.resolve_symbol(handler, ctx.by_ref());
+
                 if let Ok(result) = result {
                     expr.resolved_call_path_binding = Some(TypeBinding::<
                         ResolvedCallPath<ParsedDeclId<FunctionDeclaration>>,
@@ -547,13 +538,11 @@ impl ResolveSymbols for ExpressionKind {
                 .iter_mut()
                 .for_each(|e| e.resolve_symbols(handler, ctx.by_ref())),
             ExpressionKind::Struct(expr) => {
-                expr.call_path_binding
-                    .resolve_symbols(handler, ctx.by_ref());
-                let result = SymbolResolveTypeBinding::resolve_symbol(
-                    &mut expr.call_path_binding,
-                    &Handler::default(),
-                    ctx.by_ref(),
-                );
+                // expr.call_path_binding
+                //     .resolve_symbols(handler, ctx.by_ref());
+
+                let result = expr.call_path_binding.resolve_symbol(handler, ctx.by_ref());
+
                 if let Ok(result) = result {
                     expr.resolved_call_path_binding = Some(TypeBinding::<
                         ResolvedCallPath<ParsedDeclId<StructDeclaration>>,
@@ -604,7 +593,22 @@ impl ResolveSymbols for ExpressionKind {
             }
             ExpressionKind::Subfield(expr) => expr.prefix.resolve_symbols(handler, ctx),
             ExpressionKind::DelineatedPath(expr) => {
-                expr.call_path_binding.resolve_symbols(handler, ctx)
+                let result =
+                    expr.call_path_binding
+                        .resolve_symbol(handler, ctx.by_ref(), self.span.clone());
+
+                if let Ok(_result) = result {
+                //     expr.resolved_call_path_binding = Some(TypeBinding::<
+                //         ResolvedCallPath<ParsedDeclId<StructDeclaration>>,
+                //        > {
+                //         inner: ResolvedCallPath {
+                //             decl: result,
+                //             unresolved_call_path: expr.call_path_binding.inner.clone(),
+                //         },
+                //         span: expr.call_path_binding.span.clone(),
+                //         type_arguments: expr.call_path_binding.type_arguments.clone(),
+                //     });
+                }
             }
             ExpressionKind::AbiCast(expr) => {
                 expr.abi_name.resolve_symbols(handler, ctx.by_ref());
@@ -644,3 +648,16 @@ impl ResolveSymbols for ExpressionKind {
         }
     }
 }
+
+impl<T> ResolveSymbols for TypeBinding<T> {
+    fn resolve_symbols(&mut self, handler: &Handler, mut ctx: SymbolResolveContext) {
+        match self.type_arguments {
+            TypeArgs::Regular(ref mut args) => args
+                .iter_mut()
+                .for_each(|arg| arg.resolve_symbols(handler, ctx.by_ref())),
+            TypeArgs::Prefix(ref mut args) => args
+                .iter_mut()
+                .for_each(|arg| arg.resolve_symbols(handler, ctx.by_ref())),
+        }
+    }
+}

sway-core/src/transform/to_parsed_lang/convert_parse_tree.rs

@@ -2903,6 +2903,7 @@ fn path_expr_to_expression(
         Expression {
             kind: ExpressionKind::DelineatedPath(Box::new(DelineatedPathExpression {
                 call_path_binding,
+                resolved_call_path_binding: None,
                 args: None,
             })),
             span,