Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly bail when trying to add the same versioned component #655

Open
alfiedotwtf opened this issue Aug 26, 2024 · 2 comments
Open

Possibly bail when trying to add the same versioned component #655

alfiedotwtf opened this issue Aug 26, 2024 · 2 comments
Labels
question Further information is requested

Comments

@alfiedotwtf
Copy link
Contributor

In src/ops/fuelup_component/add.rs's add() function, should we warn then bail if the requesting version is what we already have?

@alfiedotwtf alfiedotwtf added the question Further information is requested label Aug 26, 2024
@alfiedotwtf
Copy link
Contributor Author

alfiedotwtf commented Aug 27, 2024

Maybe not. I'm now thinking clobbering is probably the right thing to do, especially when someone accidentally kills their local toolchain

@sdankel
Copy link
Member

sdankel commented Sep 6, 2024

If it's what they already have, I think we should print an info message and do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants