Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance of transaction approval from dapp #1622

Open
LuizAsFight opened this issue Oct 21, 2024 · 0 comments · May be fixed by #1794
Open

improve performance of transaction approval from dapp #1622

LuizAsFight opened this issue Oct 21, 2024 · 0 comments · May be fixed by #1794
Assignees

Comments

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Oct 21, 2024

the transaction approval step has some logics to estimate fee, get tips values, and some steps in the machine made before the transaction shows up to approve.

we should make this work on background, then when the wallet shows the dapp screen we already have the values pre-set, not needing to wait for response on requests

the objective here is to make the transaction approval process more quick


PS: also the "Review" button gets enabled, then disabled(loading) then enabled again every time you start a "Send" transfer, making the user needs to click more than once. This needs to be fixed together with this issue

@LuizAsFight LuizAsFight self-assigned this Jan 7, 2025
@arthurgeron arthurgeron linked a pull request Jan 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant