Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto add sub accounts when importing from Mnemonic #1706

Open
LuizAsFight opened this issue Dec 12, 2024 · 12 comments
Open

Auto add sub accounts when importing from Mnemonic #1706

LuizAsFight opened this issue Dec 12, 2024 · 12 comments

Comments

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Dec 12, 2024

When creating an account in Fuel Wallet by importing from seed phrase, the wallet by default will only insert the first account.

This issue aims to provide the user a way to also import another accounts from same bip44 derivation that he already used in the past

We should

  • After signup, in case the user has more than 1 account with balance, show an extra step to choose accounts
  • This step should allow the user to select the accounts he wants to import
  • Accounts in the middle without balance should be hidden
  • Using the rabby example below, if the user wants to import "Account 1", "Account 2" and "Account 3".. The final result will be only "Account 1" and "Account 3". "Account 2"will be hidden in the list as it doesn't have balance or movement at all. All the others Account 4 and so on will not even be inserted in accounts list

A good UX example is how Rabby Wallet does it, allowing to import up to 50 accounts
Image

@khayss
Copy link

khayss commented Dec 12, 2024

Could I take over this issue?

I am a blockchain developer. I have experience writing smart contracts using Solidity, and Rust for EVM and non-EVM blockchains (like Solana, Cosmos, Stellar, etc). I believe my skill set can help me tackle this issue.

@MooreTheAnalyst
Copy link

Hello, i have been writing javasscript for quite a while now, i would be delighted to work on this.

@PoulavBhowmick03
Copy link

Gm, I would love to work on this
I am Poulav, an active contributor the the Starknet ecosystem, with a good experience in TS, Cairo, Rust.

I will enhance the account import functionality by extending the wallet to derive up to 50 accounts from the seed phrase After deriving, the wallet will filter accounts, showing only those with balance or transaction history in an additional step during the signup process.

ETA - 2 days

@mimisavage
Copy link

Could I take on this issue?

@BrunoAmbricca
Copy link

Mind if I take this issue?

@PoulavBhowmick03
Copy link

Could I take a shot at this?
I am Poulav, an active contributor the the Starknet ecosystem, with a good experience in TS, Cairo, Rust.
I will enhance the account import functionality. Then, the wallet will filter accounts, showing only those with balance or transaction history in an additional step during the signup process. Users can then select which accounts they want to import.
ETA - 2 days

@JoE11-y
Copy link

JoE11-y commented Dec 12, 2024

I am Edoh Joseph Onome, a Blockchain Developer with over 4 years of experience in full-stack development, would love to take this on.

Estimated Completion Time
2 days, including testing.

@kayceeDev
Copy link

May I handle this issue?

@1nonlypiece
Copy link

Hi ,
I’d like to work on this issue as I have experience in building frontend interfaces using frameworks like React and Next.js.

ETA:
I estimate completing this task in about 12-24 hours. Let me know if I can get started!

@Jagadeeshftw
Copy link

Hi,
I’d love to work on this issue as I have strong experience with front-end development. Please assign this to me, and I’ll deliver an efficient and secure PR within 12-24 hours.

@ShantelPeters
Copy link

Is it okay if I take this?

@Benjtalkshow
Copy link

I am a Full Stack Developer with a strong background in blockchain and extensive experience in Next.js/React, TypeScript, and Rust. I’ve made over 49 contributions to over 17 projects in the OnlyDust ecosystem, solving complex issues and delivering efficient, scalable solutions.

I can handle this task.
ETA is 3days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

13 participants